feat: support additional RequestInit fields#4990
Open
sahanaxzy wants to merge 11 commits intoboa-dev:mainfrom
Open
feat: support additional RequestInit fields#4990sahanaxzy wants to merge 11 commits intoboa-dev:mainfrom
sahanaxzy wants to merge 11 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4990 +/- ##
===========================================
+ Coverage 47.24% 59.01% +11.76%
===========================================
Files 476 563 +87
Lines 46892 62621 +15729
===========================================
+ Hits 22154 36954 +14800
- Misses 24738 25667 +929 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jedel1043 can you review this... |
jedel1043
reviewed
Mar 13, 2026
…nit-fields # Conflicts: # core/runtime/src/fetch/request.rs
…hanaxzy/boa into feat-fetch-requestinit-fields
Member
|
Needs rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
RequestInitwith standard Fetch options (mode,credentials,cache,redirect,referrer,referrerPolicy,integrity,keepalive), bringingnew Request(url, init)closer to browser behavior.Closes #4987
Changes
Modified
fetch/request.rsRequestInitfields listed abovemode,credentials,cache,redirect, andreferrerPolicyreferrer,integrity, andkeepaliveare accepted but currently no-ops (ready to wire up later)Modified
fetch/tests/request.rsmode/credentialsacceptance and invalidmoderejectionTesting