test(vm): add comprehensive unit tests for bytecode argument encoding and decoding (#4240)#4735
test(vm): add comprehensive unit tests for bytecode argument encoding and decoding (#4240)#4735ParthMozarkar wants to merge 2 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
|
I think you should base this off main and not off your own branch with console.table implemented |
9e5e7ef to
a37adbf
Compare
|
Thanks for pointing that out you're right. I’ve rebased the branch on top of main and force pushed the updated changes so the PR now only contains the unit test additions for #4240. Please let me know if anything else needs adjustment. 🙌 |
80ef567 to
4c566d1
Compare
|
@jedel1043 |
|
You might need to merge pull the main branch btw |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4735 +/- ##
===========================================
+ Coverage 47.24% 59.17% +11.93%
===========================================
Files 476 563 +87
Lines 46892 62363 +15471
===========================================
+ Hits 22154 36905 +14751
- Misses 24738 25458 +720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey, |
|
Hey, could you just approve the last 3 workflows awaiting so we can then merge this pr and work upon another? |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
jedel1043
left a comment
There was a problem hiding this comment.
Where are all the tests? You deleted them or something
… and decoding This commit restores the missing unit tests in args.rs and includes the approved audit.toml changes, while removing unrelated console.table changes from the PR.
so sorry i somehow replaced it or something....but now i have fixed everything....the errors of CI and also brought back the tests |
Summary
This PR adds comprehensive unit tests for bytecode argument encoding and decoding in:
core/engine/src/vm/opcode/args.rs
as requested in issue #4240.
What’s Included
Motivation
Bytecode argument handling is a critical component of the VM execution pipeline.
These tests strengthen confidence in argument parsing correctness and protect against silent corruption or unsafe memory access.
By covering both valid and invalid cases, this improves robustness and makes future refactors safer.
Verification
cargo testpasses successfully.cargo fmt.Closes #4240