Add GIFs to CI via vhs-action by nekevss · Pull Request #3810 · boa-dev/boa

nekevss · 2024-04-14T23:31:14Z

This Pull Request is to propose adding a GIF to boa_cli and the vhs-action CI to update the GIF in CI.

With vhs-action, we could also look into automating more GIFs for our docs that can be built out during the artifacts CI.

The one unfortunate thing is that the GIF generation for boa_cli won't take in any changes from boa_engine as it is set to the currently released version in it's Cargo.toml.

I am also a bit concerned about stefanzweifel/git-auto-commit-action@v4 as I'm not entirely sure how it will affect the commit history.

EDIT: VHS can be found here for reference

github-actions · 2024-04-14T23:45:48Z

Test262 conformance changes

Test result	main count	PR count	difference
Total	50,254	50,254	0
Passed	45,343	45,343	0
Ignored	1,728	1,728	0
Failed	3,183	3,183	0
Panics	0	0	0
Conformance	90.23%	90.23%	0.00%

jedel1043 · 2024-04-15T16:47:17Z

.github/workflows/artifacts.yml

+  build_cli_tape:
+    name: Generate boa_cli GIF
+    runs-on: ubuntu-latest
+    timeout-minutes: 60
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+      - run: cargo install --path ./cli
+      # Below is from vhs-actions examples
+      # https://github.com/charmbracelet/vhs-action/blob/main/examples/auto-commit.yml
+      - uses: charmbracelet/vhs-action@v1
+        with:
+          path: './.github/tapes/boa_cli.tape'
+      - uses: stefanzweifel/git-auto-commit-action@v4
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          commit_message: Update generated VHS GIF
+          branch: main
+          commit_user_name: vhs-action 📼
+          commit_user_email: actions@github.com
+          commit_author: vhs-action 📼 <actions@github.com>
+          file_pattern: '*.gif'


Was thinking more about this, and maybe this shouldn't be a direct commit, but a check on the PRs that compares the current version of the GIF with the GIF generated by the tool, and throws if both differ.

Bumps [rustls](https://github.com/rustls/rustls) from 0.22.3 to 0.22.4. - [Release notes](https://github.com/rustls/rustls/releases) - [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md) - [Commits](rustls/rustls@v/0.22.3...v/0.22.4) --- updated-dependencies: - dependency-name: rustls dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde](https://github.com/serde-rs/serde) from 1.0.197 to 1.0.198. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.197...v1.0.198) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.58 to 1.0.59. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.58...1.0.59) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.80 to 1.0.81. - [Release notes](https://github.com/dtolnay/proc-macro2/releases) - [Commits](dtolnay/proc-macro2@1.0.80...1.0.81) --- updated-dependencies: - dependency-name: proc-macro2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [syn](https://github.com/dtolnay/syn) from 2.0.59 to 2.0.60. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.59...2.0.60) --- updated-dependencies: - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.115 to 1.0.116. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.115...v1.0.116) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Implement TryFromJs for Either<L, R> * Add explicit feature in Cargo.toml

* Decouple GlobalDeclarationInstantiation from Context * Decouple EvalDeclarationInstantiation from Context * Remove `Context` from `ByteCompiler` * Fix typo * Apply review

Bumps [either](https://github.com/rayon-rs/either) from 1.10.0 to 1.11.0. - [Commits](rayon-rs/either@1.10.0...1.11.0) --- updated-dependencies: - dependency-name: either dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [hashbrown](https://github.com/rust-lang/hashbrown) from 0.14.3 to 0.14.5. - [Changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md) - [Commits](rust-lang/hashbrown@v0.14.3...v0.14.5) --- updated-dependencies: - dependency-name: hashbrown dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde](https://github.com/serde-rs/serde) from 1.0.198 to 1.0.199. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.198...v1.0.199) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.18 to 0.2.19. - [Changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md) - [Commits](rust-num/num-traits@num-traits-0.2.18...num-traits-0.2.19) --- updated-dependencies: - dependency-name: num-traits dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde](https://github.com/serde-rs/serde) from 1.0.199 to 1.0.201. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.199...v1.0.201) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [trybuild](https://github.com/dtolnay/trybuild) from 1.0.91 to 1.0.95. - [Release notes](https://github.com/dtolnay/trybuild/releases) - [Commits](dtolnay/trybuild@1.0.91...1.0.95) --- updated-dependencies: - dependency-name: trybuild dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add more zdt method implementations * Fix docs * Missed a backtick

…#4099) * Bump test262 and spidermonkey adjustments * Ignore spidermonkey tests

…4103) Bumps the rust-dependencies group with 6 updates in the / directory: | Package | From | To | | --- | --- | --- | | [serde_json](https://github.com/serde-rs/json) | `1.0.133` | `1.0.134` | | [serde](https://github.com/serde-rs/serde) | `1.0.216` | `1.0.217` | | [quote](https://github.com/dtolnay/quote) | `1.0.37` | `1.0.38` | | [syn](https://github.com/dtolnay/syn) | `2.0.90` | `2.0.93` | | [thiserror](https://github.com/dtolnay/thiserror) | `2.0.7` | `2.0.9` | | [bytemuck](https://github.com/Lokathor/bytemuck) | `1.20.0` | `1.21.0` | Updates `serde_json` from 1.0.133 to 1.0.134 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.133...v1.0.134) Updates `serde` from 1.0.216 to 1.0.217 - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.216...v1.0.217) Updates `quote` from 1.0.37 to 1.0.38 - [Release notes](https://github.com/dtolnay/quote/releases) - [Commits](dtolnay/quote@1.0.37...1.0.38) Updates `syn` from 2.0.90 to 2.0.93 - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.90...2.0.93) Updates `thiserror` from 2.0.7 to 2.0.9 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@2.0.7...2.0.9) Updates `bytemuck` from 1.20.0 to 1.21.0 - [Changelog](https://github.com/Lokathor/bytemuck/blob/main/changelog.md) - [Commits](Lokathor/bytemuck@v1.20.0...v1.21.0) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: quote dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: bytemuck dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…#4104)

Bumps the rust-dependencies group with 1 update: [syn](https://github.com/dtolnay/syn). Updates `syn` from 2.0.93 to 2.0.95 - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.93...2.0.95) --- updated-dependencies: - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improve implementation of example `JobQueue`s * Rename example files * Rewrite examples again

* Fix CI with the latest linter errors introduced in 1.84 To maintain backward compatibility, we had to move to using caller style calls (`sptr::Strict::addr(...)`) as clippy was erroneously triggering those as unused (and `.addr()` is not stabilized in 1.82). * Wrong change

* Bump temporal_rs and add Date string methods * Add zdt handling in to_instant op * Cargo fmt * Fix failing test output

* Use instead * chore: clippy.toml Co-authored-by: José Julián Espina <jedel0124@gmail.com> --------- Co-authored-by: José Julián Espina <jedel0124@gmail.com>

…4118) * Introduce `NativeAsyncJob` * Finish implementation * Docs & Reviews * Fix realm of async job * Revamp `JobQueue` into `JobExecutor` * Fix execution bug in cli executor * Propagate jobs into `JobExecutor::run_jobs`

* chore: add `From<Cow<'a, str>>` for `JsString` * chore: marked as inline

…4131) Bumps the rust-dependencies group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [bitflags](https://github.com/bitflags/bitflags) | `2.6.0` | `2.7.0` | | [clap](https://github.com/clap-rs/clap) | `4.5.23` | `4.5.26` | | [syn](https://github.com/dtolnay/syn) | `2.0.95` | `2.0.96` | | [proc-macro2](https://github.com/dtolnay/proc-macro2) | `1.0.92` | `1.0.93` | | [thiserror](https://github.com/dtolnay/thiserror) | `2.0.9` | `2.0.11` | | [futures-lite](https://github.com/smol-rs/futures-lite) | `2.5.0` | `2.6.0` | | [tokio](https://github.com/tokio-rs/tokio) | `1.42.0` | `1.43.0` | Updates `bitflags` from 2.6.0 to 2.7.0 - [Release notes](https://github.com/bitflags/bitflags/releases) - [Changelog](https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md) - [Commits](bitflags/bitflags@2.6.0...2.7.0) Updates `clap` from 4.5.23 to 4.5.26 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.5.23...clap_complete-v4.5.26) Updates `syn` from 2.0.95 to 2.0.96 - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.95...2.0.96) Updates `proc-macro2` from 1.0.92 to 1.0.93 - [Release notes](https://github.com/dtolnay/proc-macro2/releases) - [Commits](dtolnay/proc-macro2@1.0.92...1.0.93) Updates `thiserror` from 2.0.9 to 2.0.11 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@2.0.9...2.0.11) Updates `futures-lite` from 2.5.0 to 2.6.0 - [Release notes](https://github.com/smol-rs/futures-lite/releases) - [Changelog](https://github.com/smol-rs/futures-lite/blob/master/CHANGELOG.md) - [Commits](smol-rs/futures-lite@v2.5.0...v2.6.0) Updates `tokio` from 1.42.0 to 1.43.0 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.42.0...tokio-1.43.0) --- updated-dependencies: - dependency-name: bitflags dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust-dependencies - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: proc-macro2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: futures-lite dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust-dependencies - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…4126) * Bump temporal_rs and add Date string methods * Add zdt handling in to_instant op * Cargo fmt * Fix failing test output * Implement more supported to_string methods * Implement more to_string and to_json methods * Bump msrv to 1.84 to support Option::<T>::expect const fn * Revert MSRV bump * Bump temporal_rs to msrv version * Bump temporal_rs for bug fix to cross-epoch broken test

…vhs-ci

nekevss · 2025-01-16T01:31:50Z

Closing this PR in favor of another one to clean up the git history

Add vhs-action for boa_cli

6fb4289

nekevss added C-Documentation update documentation C-CLI Issues and PRs related to the Boa command line interface. C-Actions Pull requests that update Github Actions code labels Apr 14, 2024

nekevss requested a review from a team April 14, 2024 23:34

jedel1043 reviewed Apr 15, 2024

View reviewed changes

nekevss force-pushed the add-vhs-ci branch 2 times, most recently from d88ac4c to 9282888 Compare April 20, 2024 00:18

Compare GIFs in CI with ImageMagick

68c59ea

nekevss force-pushed the add-vhs-ci branch from 9282888 to 68c59ea Compare April 20, 2024 00:27

dependabot bot and others added 19 commits April 20, 2024 05:32

Implement TryFromJs for Either<L, R> (#3822)

6156768

* Implement TryFromJs for Either<L, R> * Add explicit feature in Cargo.toml

Decouple Context from ByteCompiler (#3829)

6ee208f

* Decouple GlobalDeclarationInstantiation from Context * Decouple EvalDeclarationInstantiation from Context * Remove `Context` from `ByteCompiler` * Fix typo * Apply review

Implement object keys access (#3832)

6febf7e

Implement Latin1 JsString (#3450)

3f6ee22

Fix Rust 1.78.0 Clippy lints (#3838)

5af3f7c

replace js_str with js_string (#3836)

12adec5

Switch from actions-rs/toolchain to dtolnay/rust-toolchain (#3845)

09c08c5

nekevss and others added 27 commits December 24, 2024 22:11

Add more ZonedDateTime method implementations (#4095)

68e6d49

* Add more zdt method implementations * Fix docs * Missed a backtick

Adjust call to correct method (#4096)

71c6e7b

fix very minor typo shift -> unshift (#4097)

1af4494

Bump the temporal_rs version and related changes (#4098)

fdd8acc

Bump test262 commit and changes to boa_tester to support sm changes (…

9363531

…#4099) * Bump test262 and spidermonkey adjustments * Ignore spidermonkey tests

Remove some clones and branches in hot PropertyDescriptor functions (…

13344ce

…#4104)

Enable sm test suite and fix ephemeron bug (#4107)

426503f

Cleanup CLI to use eyre + refactor patterns (#4108)

c5f2c56

Move methods of JsString to JsStr (#4106)

579c455

Remove try_break macro in favour of question mark operator (#4112)

4a15d6c

Remove keywords for boolean and null literals (#4113)

103c66e

Implement Error.isError (#4114)

ce6cfa8

Improve implementation of example JobQueues (#4111)

a235976

* Improve implementation of example `JobQueue`s * Rename example files * Rewrite examples again

Implement PlainDate string methods (#4119)

efcafda

* Bump temporal_rs and add Date string methods * Add zdt handling in to_instant op * Cargo fmt * Fix failing test output

Use cow_to_ascii_uppercase instead (#4124)

3008f1d

* Use instead * chore: clippy.toml Co-authored-by: José Julián Espina <jedel0124@gmail.com> --------- Co-authored-by: José Julián Espina <jedel0124@gmail.com>

Add From<Cow<'a, str>> for JsString (#4134)

c48056e

* chore: add `From<Cow<'a, str>>` for `JsString` * chore: marked as inline

Add vhs-action for boa_cli

79a4393

Compare GIFs in CI with ImageMagick

b6aeb7d

Take two with ascii output and diff

671c608

Merge branch 'add-vhs-ci' of https://github.com/boa-dev/boa into add-…

8bbc1e6

…vhs-ci

Refresh and fixes after fast-forwarding branch

63803b6

nekevss closed this Jan 16, 2025

nekevss deleted the add-vhs-ci branch March 21, 2025 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add GIFs to CI via vhs-action#3810

Add GIFs to CI via vhs-action#3810
nekevss wants to merge 213 commits intomainfrom
add-vhs-ci

nekevss commented Apr 14, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Apr 14, 2024 •

edited

Loading

Uh oh!

jedel1043 Apr 15, 2024 •

edited

Loading

Uh oh!

nekevss commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Uh oh!

Conversation

nekevss commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test262 conformance changes

Uh oh!

jedel1043 Apr 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nekevss commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

nekevss commented Apr 14, 2024 •

edited

Loading

github-actions bot commented Apr 14, 2024 •

edited

Loading

jedel1043 Apr 15, 2024 •

edited

Loading