google-http-client-jackson2 serializing added to comparison#75
Open
Deepscorn wants to merge 1 commit intobluelinelabs:masterfrom
Open
google-http-client-jackson2 serializing added to comparison#75Deepscorn wants to merge 1 commit intobluelinelabs:masterfrom
Deepscorn wants to merge 1 commit intobluelinelabs:masterfrom
Conversation
Member
|
If you're asking for support for serializing Thanks for adding this library to the benchmark. I'll look through the PR a bit later. |
|
Hello! |
Author
|
ErickCook, how to determing if value is absent and how to determine if it is null during parsing in LoganSquare? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Nice library! And it is cool that you already have BenchmarkDemo implemented - simple app for comparing serialization and parsing performance of popular Gson and Jackson libs. We were curios of performance of another popular library, used in some of our projects - of google-http-client-jackson2 serializer. We've implemented test like those done with other libs in BenchmarkDemo.
Here are results and code:
https://www.dropbox.com/s/qqfbm4rr5yg7pxi/Screenshot_2015-08-04-16-34-02.png?dl=0
https://www.dropbox.com/s/85del6wnyfxgpay/Screenshot_2015-08-04-16-34-56.png?dl=0
(If interested, it's Samsung Note 2 Android 4.3)
Surprising, this library is the slowest. Maybe you have some ideas why?
Please check if our benchmark is optimized enough.
The main reason why we prefer this library is that it can handle situation when json has null value vs json key is absent. It is done via Data.isNull(). And this functionality is important for us.
Are you going to add it to LoganSquare or we can do it ourselves in next pull request?