Conversation
Collaborator
bdlukaa
commented
Mar 28, 2025
- Use MDK by default on Windows;
- FPS is now supported with MDK.
- Errors are now displayed in the stream log file as well.
- Display build number on bleeding edge release. Fixes Add build number #330
There was a problem hiding this comment.
Pull Request Overview
This pull request updates dependency versions and configuration defaults to use MDK by default on Windows, adds FPS support with MDK, and displays errors in the stream log file. It also injects build info (build number and optionally a build name) into various build commands for different targets.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/unity_video_player/unity_video_player_flutter/pubspec.yaml | Updates the fvp dependency version to support new MDK features. |
| packages/unity_video_player/unity_video_player/pubspec.yaml | Changes the default package for Windows to use unity_video_player_flutter (MDK). |
| .github/workflows/build.yml | Adds extraction of build info and updates build commands to include build number and name. |
Files not reviewed (3)
- lib/screens/settings/updates_and_help.dart: Language not supported
- lib/utils/video_player.dart: Language not supported
- packages/unity_video_player/unity_video_player_flutter/lib/unity_video_player_flutter.dart: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:58
- The use of format('--build-name={0}', env.BUILD_NAME) within the GitHub Actions expression might not be supported. Consider using string concatenation or an alternative method that is compatible with GitHub Actions expression syntax.
- run: flutter build apk --verbose --split-per-abi --build-number=${{ env.BUILD_NUMBER }} ${{ env.BUILD_NAME && format('--build-name={0}', env.BUILD_NAME) }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.