Make graphql-c_parser optional with warning when unavailable #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
myron/remove-graphql-c-parser
branch
2 times, most recently
from
4935f8d to
ecfecb7
Compare
graphql-c_parser requires native C extensions which don't work on all platforms (e.g. JRuby). By making it optional, ElasticGraph can run on more platforms while still recommending the faster parser. GraphQLGemLoader loads both `graphql` and `graphql/c_parser` together. When c_parser is unavailable, prints a yellow warning to stderr (once) directing users to add the gem. Warning is suppressed on JRuby since C extensions can't work there anyway. New projects still include graphql-c_parser in their generated Gemfile since it's recommended for better performance. Co-Authored-By: Claude (global.anthropic.claude-opus-4-5-20251101-v1:0) <noreply@anthropic.com>
myronmarston
force-pushed
the
myron/remove-graphql-c-parser
branch
from
ecfecb7 to
3bc37b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-c_parser requires native C extensions which don't work on all platforms (e.g. JRuby). By making it optional, ElasticGraph can run on more platforms while still recommending the faster parser.
GraphQLGemLoader loads both
graphqlandgraphql/c_parsertogether. When c_parser is unavailable, prints a yellow warning to stderr (once) directing users to add the gem. Warning is suppressed on JRuby since C extensions can't work there anyway.New projects still include graphql-c_parser in their generated Gemfile since it's recommended for better performance.