Added swgwit signing and verification in WalletManager#459
Open
MudDev wants to merge 1 commit intoblock-core:masterfrom
Open
Added swgwit signing and verification in WalletManager#459MudDev wants to merge 1 commit intoblock-core:masterfrom
MudDev wants to merge 1 commit intoblock-core:masterfrom
Conversation
Enhanced SignMessage to handle SegWit and legacy addresses. Added FindSegWitAddress method for locating SegWit addresses. Updated VerifySignedMessage to accept generic address parameter, handle SegWit and legacy address verification, and improve error logging.
Member
|
Nice pr I'll review it tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still needs automated tests, but I figure this might be useful for anyone that needs to sign/verify with segwit addresses as I had to do recently for another project.