Add nil/null support to the cryptString struct#10
Open
sowmiyamuthuraman wants to merge 2 commits intoblaskovicz:masterfrom
Open
Add nil/null support to the cryptString struct#10sowmiyamuthuraman wants to merge 2 commits intoblaskovicz:masterfrom
sowmiyamuthuraman wants to merge 2 commits intoblaskovicz:masterfrom
Conversation
Pull Request Test Coverage Report for Build 38
💛 - Coveralls |
blaskovicz
reviewed
Oct 21, 2019
cryptkeeper.go
Outdated
| ) | ||
|
|
||
| /* NullString is an alias for sql.NullInt64 data type */ | ||
| type NullString sql.NullString |
blaskovicz
reviewed
Oct 21, 2019
cryptkeeper.go
Outdated
| driver.Valuer | ||
|
|
||
| String string | ||
| String NullString |
Owner
There was a problem hiding this comment.
it may be worth embedding the NullString struct rather than making a .String since that will cut out some code noise (ie .String.String, .String.Valid, etc)
blaskovicz
reviewed
Oct 21, 2019
cryptkeeper.go
Outdated
| func (cs *CryptString) UnmarshalJSON(b []byte) error { | ||
| var target string | ||
| if err := json.Unmarshal(b, &target); err != nil { | ||
| cs.String = NullString{Valid: false} |
sowmiyamuthuraman
force-pushed
the
Fix/#4
branch
4 times, most recently
from
5803d31 to
62ee9d1
Compare
blaskovicz
reviewed
Oct 22, 2019
cryptkeeper_test.go
Outdated
| t.Run("Value", func(t *testing.T) { | ||
| var cs CryptString | ||
| cs.String = "hello world!" | ||
| cs.NullString = sql.NullString{"hello world!", true} |
Owner
There was a problem hiding this comment.
now that you've embedded the struct, is it possible to do the following:
Suggested change
| cs.NullString = sql.NullString{"hello world!", true} | |
| cs.String = "hello world!" | |
| cs.Valid = true |
sowmiyamuthuraman
force-pushed
the
Fix/#4
branch
from
62ee9d1 to
00d90a1
Compare
blaskovicz
reviewed
Oct 23, 2019
| if err != nil { | ||
| t.Fatalf("SetCryptKey should be valid, got: '%s'", err) | ||
| } | ||
| cs := CryptString{String: "another secret text"} |
Owner
There was a problem hiding this comment.
this can stay what it was with, Valid: true, similar to how you made the change in the previous code.
blaskovicz
reviewed
Oct 23, 2019
blaskovicz
reviewed
Oct 23, 2019
blaskovicz
reviewed
Oct 23, 2019
sowmiyamuthuraman
force-pushed
the
Fix/#4
branch
from
00d90a1 to
4353c2f
Compare
Owner
|
Is it possible to add some test cases for this (specifically for Valid, and also for the null cases) and also add it to CryptBytes as well (since you already added it to CryptString)? Thank you for your help. |
Author
|
@blaskovicz for CryptBytes, as there is no structs like sql.NullString for bytes is it fine to introduce the Valid field in the CryptBytes struct. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4