Open
Conversation
billyshambrook
requested changes
Oct 29, 2016
Owner
billyshambrook
left a comment
billyshambrook
left a comment
There was a problem hiding this comment.
Hey @tdickman, sorry about the late response, somehow I missed the notification.
Thanks for catching me not hooking up the auth instance variable!
I have left some comments of some changes before I merge it.
| await self._session.close() | ||
|
|
||
| async def get(self, *, path=None, params=None): | ||
| async def get(self, *, path=None, params={}): |
Owner
There was a problem hiding this comment.
This should be None as you should not have mutable default arguments - here's a good write up of the side effects (https://pythonconquerstheuniverse.wordpress.com/category/python-gotchas/)
| url = posixpath.join(self._base_url, path.strip('/')) if path else self._base_url | ||
| url += '.json' | ||
| data = json.dumps(value) if value else None | ||
| if self._auth: |
Owner
There was a problem hiding this comment.
Because I allow any arbitrary params to be given in each call, a user may override the auth set when creating the instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added authentication support - I'd love to get this merged, so let me know what I need to do to make that happen. Happy to add tests, etc if needed, just let me know.