Merged
Conversation
✅ Deploy Preview for seader canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made two related changes on feat-multi-card. I started using the credential type returned by requestPacs2 instead of ignoring it, to disambiguate 14443a. The second change fixes the success flow for reads after the multi-tech work. I wanted success to be worker-owned, meaning the UI should only move on after the worker has actually finished, stopped the poller, and cleaned everything up. That avoids races between the UI and the NFC stack.
Once I removed the old direct success event from the protocol side, I missed one completion handoff: after a successful PACS2 decode, the worker was never being told that the read was done. I'm pretty sure that’s why some read as 14a cases would hang after the credential was already parsed. I fixed that by explicitly marking the worker as complete when PACS2 decoding succeeds, so the worker can unwind normally and then emit the single success event.