Added the ability to optionally wrap with sibling styles instead of, …#5
Open
eoingroat wants to merge 1 commit intobenignware:masterfrom
eoingroat:master
Open
Added the ability to optionally wrap with sibling styles instead of, …#5eoingroat wants to merge 1 commit intobenignware:masterfrom eoingroat:master
eoingroat wants to merge 1 commit intobenignware:masterfrom
eoingroat:master
Conversation
…or as well as, parent styles
Member
|
Many thanks for your PR. This definitely makes sense. Presumably i'm going to find some time to check and merge it by tomorrow night. Do you have a concrete (tiny, pseudo) example of integrating css-wrap for building an antd-based application? Being well experienced with react, i'm not yet familiar with antd library and would be very interested in having a look at that use-case. For now, thx and cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or as well as, parent styles
The drive for this is in using https://github.com/Y-Sree-Chaitanya/wrap-css-loader to prevent imports from polluting global CSS. This broke when using certain antd components because the class was assumed to be a sibling, to fix this I have introduced the notion of "wrapping with siblings".