Conversation
Update docstrings for Session and CookieSession classes in session.py to properly document: - True (default): session cookie that expires when browser closes - False: cookie set to never expire (year 2038) - datetime: specific expiration date - timedelta: expiration relative to current time - int: seconds until expiration Also update configuration.rst with complete and accurate documentation about cookie_expires, including the relationship to the timeout parameter. Resolves issues #116 and #31 by clarifying boolean behavior and fixing the incorrect default value documentation. Co-authored-by: amol- <601423+amol-@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix documentation for cookie_expires in beaker.session class
Fix cookie_expires documentation to clarify boolean behavior and correct default value
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cookie_expiresdocumentation was incorrect: stated default was "never expiring" when it's actuallyTrue(session cookie), and boolean behavior was unclear. Fixes #116 and #31.Changes
session.py: Updated docstrings for
SessionandCookieSessionclasses with complete type semantics:True(default): session cookie, expires when browser closesFalse: never expires (year 2038)datetime/timedelta/int: specific expirationcookie_expires(browser-side) fromtimeout(server-side)configuration.rst: Fixed default value, clarified boolean meanings, documented
timedeltatypeExample
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.