Open
Conversation
illicitonion
approved these changes
Feb 8, 2026
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM! Do you want to wire up CI publishing like we have in
rules_rust/.github/workflows/cargo_bazel_release.yaml
Lines 43 to 47 in 2c3469e
UebelAndre
requested changes
Feb 17, 2026
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
LGTM! Do you want to wire up CI publishing like we have in
rules_rust/.github/workflows/cargo_bazel_release.yaml
Lines 43 to 47 in 2c3469e
?
I think if this gets added then the change looks good to me!
| macro_rules! rlocation { | ||
| ($r:expr, $path:expr) => { | ||
| $r.rlocation_from($path, env!("REPOSITORY_NAME")) | ||
| { |
Collaborator
There was a problem hiding this comment.
What are these changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the runfiles crate on crates.io is 3 years old. This PR allows downstream users to depend on runfiles via a
gitoverride in their Cargo.toml, so they can build both with Cargo and bazelcloses #1592