-
Notifications
You must be signed in to change notification settings - Fork 3
Add (build) indicator next to model name for build mode comments #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
julianbenegas
wants to merge
1
commit into
main
Choose a base branch
from
forums/build-mode-indicator-a3613
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build mode indicator fails to display for subsequent messages in multi-turn conversations because mode metadata is only added to the first message of the first step
View Details
📝 Patch Details
Analysis
Bug Explanation
In
agent/response-agent.tsaround line 367, the code conditionally adds mode metadata only when three conditions are met simultaneously:isFirstStep && index === 0 && mode === "build"The problem manifests in two scenarios:
Scenario 1: Multiple messages in first step
When the AI generates multiple messages (e.g., text + tool use), only the first message (index === 0) gets the mode metadata. Subsequent messages in the same first step won't have it.
Scenario 2: Multi-turn conversations
When
stepCount > 0(happens in the while loop inresponseAgentlines 71-86),isFirstStep = newMessages.length === 0becomes false. This means NO messages in steps 2 and beyond receive the mode metadata, even though they were generated in build mode.In
comment-thread.tsxline 84, the code checks:This check uses
.some(), which needs at least ONE message with the mode metadata. The current logic in response-agent makes this unreliable because:Result: The build mode indicator "(build)" fails to display for real-world multi-turn conversations or when the first response generates multiple messages.
The Fix
Changed line 367 in
agent/response-agent.tsfrom:To:
This ensures that EVERY message generated when mode="build" receives the mode metadata, regardless of step number or message index. Now the
.some()check in comment-thread.tsx will reliably find the build mode indication, guaranteeing the indicator displays correctly in all cases.The fix is minimal, non-breaking, and doesn't require database migrations because it only changes how existing metadata is populated.