Support v-prediction objective, fix some SDXL models outputting clouds#26
Open
ZDisket wants to merge 3 commits intoaxodox:mainfrom
Open
Support v-prediction objective, fix some SDXL models outputting clouds#26ZDisket wants to merge 3 commits intoaxodox:mainfrom
ZDisket wants to merge 3 commits intoaxodox:mainfrom
Conversation
Owner
|
Thanks, I will look into it. |
Owner
|
I am preparing a larger reorganization of the code on a branch to make it more flexible for future development, I will migrate your change once I finish it. Currently I am also working on a change for DirectML ONNX executor which should reduce VRAM usage a lot, particularly for VAE decode, where it could be reduced by 75% or more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you try to use models trained with the v-prediction objective with the current repo, you'll get nonsense output. I detailed in this issue
This PR adds v-prediction to both schedulers, and aligns the Euler Ancestral one closer to the HF implementation (the original doesn't use
predictedOriginalSample).Also, with some SDXL models, it will output nonsense/clouds. This is Pony Diffusion V6 XL

This is because some of them demand that we sample from the penultimate layer on both text encoders, which the Huggingface implementation does by default. This change fixes that model and (feels like) it makes other SDXL models follow prompts better.