Add Escape Sequences to Shell Sessions#96
Open
neilramsay wants to merge 3 commits intoaws:mainlinefrom
Open
Conversation
Add a struct for tracking the state of a possible escape sequence. We're using the same escape sequence as SSH, which is a newline followed by tilde (~). See https://linux.die.net/man/1/ssh. To do this we need to track keypresses over multiple iterations of the Unix and Windows handleKeyboardInput function loops. In particular we need to half trigger on newline, and then fully trigger on tilde (~).
Implement a function to process key presses looking for the escape sequence, and storing the state in the Shell Session Escape Sequence tracking struct. We do not want to send the tilde (~), or the command to the target. To do this we need to indicate to the Unix and Windows handleKeyboardInput functions whether to send the keypress to the target of this session, or skip the loop iteration. As a start, the following commands have been implemented: - ~? help - ~~ send ~ to the connected session - ~- disable escape sequences for the rest of this session - ~. disconnect and terminate the session
Add the handleEscapeSequence function to both the Unix and Windows handleKeyboardInput functions.
Author
|
Some extra details:
|
Author
|
@Yangtao-Hua is there anything else this PR needs? |
Contributor
|
Hi @neilramsay, I will notify the team about this feature request to prioritize it. We appreciate the value this functionality would bring to our users, as it aligns well with familiar SSH behavior. We will keep you updated when there is progress. Thank you again for your understanding and continued interest in improving the session-manager-plugin. Thanks, |
Author
|
@Yangtao-Hua any updates on this and #97 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes:
Add a SSH-like escape sequence to shell sessions.
As a start, the only functionality is terminating the session.
This allows an operator to terminate their session if the remote target becomes unresponsive.
Warning
Please note that session termination does not current work for AWS SSO / Identity Center authentication credentials.
This is due to a bug in session-manager-plugin, which interferes with refreshing SSO tokens.
(I'll raise a separate PR for that issue).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.