fix(util-user-agent): remove legacy label for pre-SRA retries #7654
+61
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Differentiate pre-SRA retries into standard (E) and adaptive (F) - Remove incorrect 'D' (legacy) attribution - Add tests for pre-SRA standard and adaptive modes - Fixes aws#7574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where pre-SRA (standard and adaptive) retry modes were incorrectly attributed as "Legacy" (feature ID
D) in the User-Agent header.With this change, pre-SRA retry modes are correctly identified:
EFAnd the Legacy
Dtag is removed when these modes are active.Issue links
Fixes #7574
Testing
Added a new test file
packages/middleware-user-agent/src/check-features-repro.spec.tsto verify that:standardretry mode without SRA produces featureEand notD.adaptiveretry mode without SRA produces featureFand notD.