Merged
Conversation
sparrc
previously approved these changes
Mar 3, 2026
c690a24 to
476ebda
Compare
mye956
previously approved these changes
Mar 5, 2026
singholt
reviewed
Mar 5, 2026
singholt
approved these changes
Mar 5, 2026
mye956
approved these changes
Mar 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update golang version to 1.25.7. Also make necessary changes to support unit testing with golang 1.25. These changes are needed because
GOEXPERIMENT=nocoverageredesignflag is no longer supported.Implementation
GOEXPERIMENT=nocoverageredesignis no more supported. For context, this flag turns off the way golang calculates go cover by default since go 1.22 onwards and was introduced in a previous PR - update go to 1.22.3 #4184 . However, the fix was temporary. Since now the flag is no more supported.nocoverageredesignflag), test coverage gets diluted by autogenerated code - packages such as mocks, interfaces, etc, which do not have any tests. While previously, packages which did not have any tests did not contribute to coverage at all, with new default, they contribute 0 to coverage and some number of lines to inflate the code size, bringing down test coverage.(https://go.dev/doc/go1.22)
coverpkgflag. When calculating test cover, we pass all the packages which actually have tests for them to thego testcommand to measure test coverage. This flag measures cross package test coverage against only the packages provided.coverpkgtesting is cross package, and within those packages, the actual test coverage reported goes up slightly with this change. This is possibly more correct too.Testing
Test coverage with GOEXPERIMENT=nocoverageredesign and golang 1.24
Test coverage with -coverpkg and golang 1.25
Description for the changelog
Enhancement - Update go version to 1.25.7
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.