Optionally validate the payload of a token before verification#972
Open
georgejmx wants to merge 2 commits intoauth0:masterfrom
Open
Optionally validate the payload of a token before verification#972georgejmx wants to merge 2 commits intoauth0:masterfrom
georgejmx wants to merge 2 commits intoauth0:masterfrom
Conversation
georgejmx
commented
Jun 9, 2024
|
|
||
| it('should check that the payload satisfies the provided callback', function () { | ||
| const token = jwt.sign({ foo: 'bar' }, KEY); | ||
| const result = jwt.verify(token, KEY, undefined, undefined, testPayloadCallback); |
Author
There was a problem hiding this comment.
Not keen on the double undefined, however had concerns around making any other changes to the function signature wrt backward compatibility
Author
There was a problem hiding this comment.
Here is a repo that demos the feature https://github.com/georgejmx/demo-jsonwebtoken-payload-callback
Any more manual testing you need just let me know @Vero7979
This was referenced Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the only way to know that a token returned from
jwt.verify()is of the correct format is by verifying the payload returned from the function. This MR makes it so the user can specify a callbackpayloadCallbackthat can be provided as an argument tojwt.verify(), which facilitates sanitising the token payload before it is verifiedReferences
Closes #955
Testing
Checklist