This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Remove windows-build installation step#704
Merged
darangi merged 1 commit intoatom:masterfrom Sep 29, 2021
Merged
Conversation
Contributor
|
Thanks for the contribution @icecream17 🙇🏾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off atom/github@9207c7b
Requirements
Description of the Change
Remove windows-build installation step
The windows ci tests are failing. Based off the similar error fixed by atom/github@9207c7b
Alternate Designs
Benefits
fixes window
Possible Drawbacks
fixes #696
will probably cause #695 and #698's tests to pass
Applicable Issues