Skip to content

Add NoResetOnClose=true to PostgreSQL connection strings missing it#2154

Merged
LoopedBard3 merged 1 commit intoaspnet:mainfrom
LoopedBard3:FixMissedNoResetOnCloseBenchmarkUpdates
Feb 19, 2026
Merged

Add NoResetOnClose=true to PostgreSQL connection strings missing it#2154
LoopedBard3 merged 1 commit intoaspnet:mainfrom
LoopedBard3:FixMissedNoResetOnCloseBenchmarkUpdates

Conversation

@LoopedBard3
Copy link
Contributor

Commit 36ab8b9 removed Multiplexing=true and tightened Program.cs to require NoResetOnClose=true, but missed adding it to connection strings that previously relied on Multiplexing=true to pass the check.

Fixes Fortunes, Fortunes EF, and Fortune Dapper failures in the benchmarks-ci-01 Trends Database pipeline.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates PostgreSQL connection strings in benchmark scenario YAMLs to include NoResetOnClose=true, aligning scenario configuration with the stricter Npgsql connection-string validation enforced by src/Benchmarks/Program.cs.

Changes:

  • Add NoResetOnClose=true to PostgreSQL connection strings in scenarios/mono.benchmarks.yml.
  • Add NoResetOnClose=true to the PostgreSQL connection string used by scenarios/database.benchmarks.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scenarios/mono.benchmarks.yml Adds NoResetOnClose=true to multiple PostgreSQL scenario connection strings to satisfy runtime validation.
scenarios/database.benchmarks.yml Adds NoResetOnClose=true to the PostgreSQL job connection string to prevent startup validation failures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Commit 36ab8b9 removed Multiplexing=true and tightened Program.cs to
require NoResetOnClose=true, but missed adding it to connection strings
that previously relied on Multiplexing=true to pass the check.

Fixes Fortunes, Fortunes EF, and Fortune Dapper failures in the
benchmarks-ci-01 Trends Database pipeline.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@LoopedBard3 LoopedBard3 force-pushed the FixMissedNoResetOnCloseBenchmarkUpdates branch from 90ac1b4 to ad2a5cc Compare February 19, 2026 00:49
@LoopedBard3 LoopedBard3 merged commit 1e6374b into aspnet:main Feb 19, 2026
2 checks passed
@LoopedBard3 LoopedBard3 deleted the FixMissedNoResetOnCloseBenchmarkUpdates branch February 19, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments