Add NoResetOnClose=true to PostgreSQL connection strings missing it#2154
Merged
LoopedBard3 merged 1 commit intoaspnet:mainfrom Feb 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates PostgreSQL connection strings in benchmark scenario YAMLs to include NoResetOnClose=true, aligning scenario configuration with the stricter Npgsql connection-string validation enforced by src/Benchmarks/Program.cs.
Changes:
- Add
NoResetOnClose=trueto PostgreSQL connection strings inscenarios/mono.benchmarks.yml. - Add
NoResetOnClose=trueto the PostgreSQL connection string used byscenarios/database.benchmarks.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scenarios/mono.benchmarks.yml | Adds NoResetOnClose=true to multiple PostgreSQL scenario connection strings to satisfy runtime validation. |
| scenarios/database.benchmarks.yml | Adds NoResetOnClose=true to the PostgreSQL job connection string to prevent startup validation failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Commit 36ab8b9 removed Multiplexing=true and tightened Program.cs to require NoResetOnClose=true, but missed adding it to connection strings that previously relied on Multiplexing=true to pass the check. Fixes Fortunes, Fortunes EF, and Fortune Dapper failures in the benchmarks-ci-01 Trends Database pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
90ac1b4 to
ad2a5cc
Compare
sebastienros
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 36ab8b9 removed Multiplexing=true and tightened Program.cs to require NoResetOnClose=true, but missed adding it to connection strings that previously relied on Multiplexing=true to pass the check.
Fixes Fortunes, Fortunes EF, and Fortune Dapper failures in the benchmarks-ci-01 Trends Database pipeline.