Skip to content

Fix tar-fs CVE by overriding to 3.1.1#2150

Merged
LoopedBard3 merged 1 commit intoaspnet:mainfrom
DrewScoggins:fix/tar-fs-cve
Feb 9, 2026
Merged

Fix tar-fs CVE by overriding to 3.1.1#2150
LoopedBard3 merged 1 commit intoaspnet:mainfrom
DrewScoggins:fix/tar-fs-cve

Conversation

@DrewScoggins
Copy link
Contributor

@DrewScoggins DrewScoggins commented Feb 9, 2026

Add tar-fs 3.1.1 override in package.json to address path traversal vulnerability (CVE) in tar-fs < 3.1.1, a transitive dependency via puppeteer/@puppeteer/browsers.

Copy link
Contributor

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@LoopedBard3 LoopedBard3 self-requested a review February 9, 2026 18:31
Update tar-fs override from 3.0.7 to 3.1.1 in package.json to address
additional CVE requiring at least version 3.1.1.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Lighthouse benchmark app’s Node dependency graph to mitigate a known tar-fs path traversal vulnerability coming in transitively via puppeteer / @puppeteer/browsers.

Changes:

  • Add an npm overrides entry to force tar-fs to a non-vulnerable version.
  • Regenerate package-lock.json, including upgrading it to lockfileVersion: 3.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/BenchmarksApps/Lighthouse/package.json Adds a tar-fs override alongside the existing cookie override.
src/BenchmarksApps/Lighthouse/package-lock.json Updates the resolved dependency tree and switches the lockfile to v3 format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 3 to +6
"version": "1.0.0",
"lockfileVersion": 1,
"lockfileVersion": 3,
"requires": true,
"dependencies": {
"@babel/code-frame": {
"packages": {
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates the lockfile format to lockfileVersion 3. That format requires npm versions that understand v3 lockfiles; otherwise npm ci will fail. Please ensure the Lighthouse Docker build environment uses npm 9+ (or pin/upgrade npm in the Dockerfile), or keep the lockfile at the version supported by the repo’s build tooling.

Copilot uses AI. Check for mistakes.
@sebastienros
Copy link
Member

Note I don't think the benchmark has run in more than a year /cc @MackinnonBuck

@LoopedBard3 LoopedBard3 changed the title Fix tar-fs CVE by overriding to 3.0.7 Fix tar-fs CVE by overriding to 3.1.1 Feb 9, 2026
@LoopedBard3 LoopedBard3 merged commit 74100db into aspnet:main Feb 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments