Skip to content

Fix BasicGoServer Docker build by running go mod tidy #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoopedBard3 merged 2 commits into from
Feb 10, 2026
Merged

Fix BasicGoServer Docker build by running go mod tidy #2149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04fffea
Fix BasicGoServer Docker build by running go mod tidy
LoopedBard3 Feb 6, 2026
dd4bb30
Merge branch 'main' into FixFailingGolangGRPC
LoopedBard3 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/BenchmarksApps/Grpc/BasicGoServer/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
module github.com/grpc/grpc-dotnet

go 1.21
go 1.23.0
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go directive was bumped from 1.21 to 1.23.0, which makes this module require a newer toolchain than the other Go benchmark apps in this repo (e.g., GoServer/GoClient still use go 1.21). If this change is unintentional from running go mod tidy, consider reverting it back to the repo’s baseline Go version (and matching the existing go 1.xx format) to avoid breaking builds/environments pinned to 1.21.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@DrewScoggins DrewScoggins Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably follow this guidance unless 1.23 is required.

Copy link
Contributor Author

@LoopedBard3 LoopedBard3 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the go directive set to 1.21 I end up with this error when building the docker file:

=> ERROR [build-env 4/4] RUN go build -o todo                                                                                                                                                                                                                           3.0s
------
 > [build-env 4/4] RUN go build -o todo:
0.312 go: downloading google.golang.org/protobuf v1.34.1
0.314 go: downloading google.golang.org/grpc v1.64.1
0.915 go: downloading golang.org/x/net v0.38.0
0.915 go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240521202816-d264139d666e
0.915 go: downloading golang.org/x/sys v0.31.0
1.370 go: downloading golang.org/x/text v0.23.0
2.486 go: updates to go.mod needed; to update it:
2.486   go mod tidy
------

 2 warnings found (use docker --debug to expand):
 - JSONArgsRecommended: JSON arguments recommended for ENTRYPOINT to prevent unintended behavior related to OS signals (line 12)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 7)
Dockerfile:4
--------------------
   2 |     WORKDIR /src
   3 |     COPY . ./
   4 | >>> RUN go build -o todo
   5 |
   6 |     FROM alpine
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c go build -o todo" did not complete successfully: exit code: 1

It seems that we will need to keep this updated.


require (
google.golang.org/grpc v1.64.1
google.golang.org/protobuf v1.34.1
github.com/golang/glog v1.2.4
)

require (
golang.org/x/net v0.38.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
golang.org/x/sys v0.31.0 // indirect
golang.org/x/text v0.23.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240521202816-d264139d666e // indirect
)
12 changes: 6 additions & 6 deletions src/BenchmarksApps/Grpc/BasicGoServer/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=
golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA=
golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=
golang.org/x/text v0.21.0/go.mod h1:4IBbMaMmOPCJ8SecivzSH54+73PCFmPWxNTLm+vZkEQ=
golang.org/x/net v0.38.0 h1:vRMAPTMaeGqVhG5QyLJHqNDwecKTomGeqbnfZyKlBI8=
golang.org/x/net v0.38.0/go.mod h1:ivrbrMbzFq5J41QOQh0siUuly180yBYtLp+CKbEaFx8=
golang.org/x/sys v0.31.0 h1:ioabZlmFYtWhL+TRYpcnNlLwhyxaM9kWTDEmfnprqik=
golang.org/x/sys v0.31.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
golang.org/x/text v0.23.0 h1:D71I7dUrlY+VX0gQShAThNGHFxZ13dGLBHQLVl1mJlY=
golang.org/x/text v0.23.0/go.mod h1:/BLNzu4aZCJ1+kcD0DNRotWKage4q2rGVAg4o22unh4=
google.golang.org/genproto/googleapis/rpc v0.0.0-20240521202816-d264139d666e h1:Elxv5MwEkCI9f5SkoL6afed6NTdxaGoAo39eANBwHL8=
google.golang.org/genproto/googleapis/rpc v0.0.0-20240521202816-d264139d666e/go.mod h1:EfXuqaE1J41VCDicxHzUDm+8rk+7ZdXzHV0IhO/I6s0=
google.golang.org/grpc v1.64.1 h1:LKtvyfbX3UGVPFcGqJ9ItpVWW6oN/2XqTxfAnwRRXiA=
Expand Down
Loading