Fix lint issues in vue, express, node, i18n, react-router, tanstack-router#328
Open
DonOmalVindula wants to merge 3 commits intoasgardeo:mainfrom
Open
Fix lint issues in vue, express, node, i18n, react-router, tanstack-router#328DonOmalVindula wants to merge 3 commits intoasgardeo:mainfrom
DonOmalVindula wants to merge 3 commits intoasgardeo:mainfrom
Conversation
b18ccaa to
e7bead9
Compare
brionmario
previously approved these changes
Jan 22, 2026
1043996 to
019cd19
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request focuses on code quality improvements and modernization across the
express,i18n, andnodepackages. The main changes include updating copyright notices, improving code style and consistency, refactoring legacy code for better readability and maintainability, and enhancing TypeScript usage for type safety.Code Modernization and Refactoring
AsgardeoNodeClientandAsgardeoNodeCoreclasses to use more descriptive names (e.g.,_authCore→authCore,_auth→auth) and updated all method references accordingly for clarity and consistency (packages/node/src/__legacy__/client.ts,packages/node/src/__legacy__/core/authentication.ts). [1] [2]UUID_VERSION: number, and defining an interface forLOGGER_CONFIG(packages/node/src/__legacy__/constants/logger-config.ts,packages/node/src/__legacy__/constants/uuid-config.ts). [1] [2]Copyright and License Updates
packages/express/src/index.ts,packages/node/src/__legacy__/constants/index.ts,packages/node/src/__legacy__/constants/logger-config.ts,packages/node/src/__legacy__/constants/uuid-config.ts,packages/node/src/__legacy__/core/authentication.ts). [1] [2] [3] [4] [5]Code Style and Linting
packages/express/src/index.ts,packages/node/src/__legacy__/constants/index.ts). [1] [2].eslintignoreand disabled specific ESLint rules in config and test files to reduce unnecessary linting errors and improve developer experience (packages/express/.eslintignore,packages/i18n/vitest.config.ts,packages/express/vitest.config.ts,packages/i18n/src/translations/hi-IN.ts). [1] [2] [3] [4]Test and Utility Improvements
getDefaultI18nBundles.test.ts(packages/i18n/src/utils/__tests__/getDefaultI18nBundles.test.ts). [1] [2]These changes collectively improve code maintainability, readability, and compliance with modern TypeScript and JavaScript standards.
Checklist
Security checks