test(node): add unit tests to node sdk#206
Open
Lakshan-Chamoditha-Perera wants to merge 1 commit intoasgardeo:mainfrom
Open
test(node): add unit tests to node sdk#206Lakshan-Chamoditha-Perera wants to merge 1 commit intoasgardeo:mainfrom
Lakshan-Chamoditha-Perera wants to merge 1 commit intoasgardeo:mainfrom
Conversation
3 tasks
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
brionmario
reviewed
Oct 20, 2025
Member
There was a problem hiding this comment.
We use vitest instead of Jest.
Lets utilize that instead.
https://github.com/asgardeo/javascript/blob/52d5d7b987856e4896ea61f58d8d0f37115c82f8/packages/node/vitest.config.ts
Member
There was a problem hiding this comment.
Please also check the Build failure and the Type Check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces unit tests for the Node SDK to improve code reliability and maintainability.
The tests are implemented using Jest and cover core functionalities such as cookie configuration, session ID generation, and helper utilities.
Key Additions:
jest.config.js) and test-specific TypeScript config (tsconfig.spec.json).packages/node/src/__tests__/, including:constants/CookieConfig.test.tsfixtures/cookieOptions.tshelpers/mockHelpers.tsutils/generateSessionId.test.tsutils/getSessionCookieOptions.test.tspackage.jsonto include Jest dependencies and test scripts.