Draft
Conversation
3 tasks
… multiple packages for consistency & storybook requirements.
AuraOfDivinity
force-pushed
the
storybooks-integration
branch
from
04a67d0 to
e81260f
Compare
…us configurations and callbacks
brionmario
reviewed
Oct 19, 2025
| }, | ||
| "plugins": [] | ||
| } No newline at end of file | ||
| "plugins": [ |
Member
There was a problem hiding this comment.
We prefer not to use nx for anything other than build caching.
Shall we use the standalone storybook instead.
brionmario
reviewed
Oct 19, 2025
Member
There was a problem hiding this comment.
Whatever the new packages we introduce (storybook related) should be in the react package's package.json.
brionmario
reviewed
Oct 19, 2025
| "next": "^15.3.2", | ||
| "prettier": "^2.6.2", | ||
| "react": "^19.1.0", | ||
| "react": "^19.2.0", |
Member
There was a problem hiding this comment.
Any reason for bumping the React version?
brionmario
reviewed
Oct 19, 2025
| @@ -0,0 +1,25 @@ | |||
| import type {StorybookConfig} from '@storybook/react-vite'; | |||
Member
There was a problem hiding this comment.
Lets add out license header to all the newly added files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request integrates Storybooks. PR will be updated to include additional details as more changes are made.
Related Issues
Storybookfor Component Library Documentation and Testing #146Checklist
.storybookconfiguration for@asgardeo/react.storybookconfiguration for@asgardeo/nextjs.stories.tsxfiles for key components (e.g.,OrganizationSwitcher,CreateOrganization) covering various states (default, loading, error)packages/javascript/src/i18n/) and enable locale switching in Storybookpackage.jsonand configure static build output for deploymentSecurity checks