chore: update display for offer on top of limited partner offer#16908
chore: update display for offer on top of limited partner offer#16908
Conversation
| List price: {artworkData.price} | ||
| </Text> | ||
| {isOfferOnTopOfPartnerOffer && | ||
| orderData.lineItems?.[0]?.listPrice?.__typename === "Money" && |
There was a problem hiding this comment.
Non-blocking: can we extract these conditions to a separate variable
| timer.hasValidRemainingTime && ( | ||
| <Text variant="sm" color="blue100" textAlign="left"> | ||
| Gallery offer: {orderData.lineItems[0].listPrice.display}{" "} | ||
| <span style={{ whiteSpace: "nowrap" }}> |
There was a problem hiding this comment.
Curious what this looks like on mobile when the text overflows. Do you have a screenshot?
There was a problem hiding this comment.
This is actually more for the web if the screen is smaller. For mobile the whole thing is rendered as one column and things fit in one row:
| const isOfferOnTopOfPartnerOffer = | ||
| isOffer && orderData.source === "PARTNER_OFFER" | ||
|
|
||
| // Calculate timer for partner offer |
There was a problem hiding this comment.
Non-blocking: this might be nice to have in a util file if we feel it's going to be reused
There was a problem hiding this comment.
This whole timer at some point should probably be consolidated. I created a separate ticket for that on CMS side (https://artsyproduct.atlassian.net/browse/EMI-3024) We probably want to do it here as well. I'll add one.
There was a problem hiding this comment.
Ok. Added one for Force as well: https://artsyproduct.atlassian.net/browse/EMI-3115
#7110 Bundle Size — 8.65MiB (-0.08%).855961c(current) vs 6e64382 main#7107(baseline) Warning Bundle contains 31 duplicate packages – View duplicate packages Bundle metrics
|
| Current #7110 |
Baseline #7107 |
|
|---|---|---|
 Initial JS |
2.84MiB(-0.13%) |
2.84MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
19.53% |
15.84% |
| Chunks |
110 |
110 |
| Assets |
113 |
113 |
| Modules |
5520(-0.04%) |
5522 |
| Duplicate Modules |
618 |
618 |
| Duplicate Code |
4.94%(+0.2%) |
4.93% |
| Packages |
250 |
250 |
| Duplicate Packages |
30 |
30 |
Bundle size by type 1 change 1 improvement
| Current #7110 |
Baseline #7107 |
|
|---|---|---|
| JS |
8.5MiB (-0.08%) |
8.51MiB |
| Other |
152.75KiB |
152.75KiB |
Bundle analysis report Branch oxaudo/partner_offer Project dashboard
Generated by RelativeCI Documentation Report issue
2 participants
Address final variation for https://artsyproduct.atlassian.net/browse/EMI-3108
Current look:
