chore: render errors as content (preserving nav, footer, etc.) + redirect fix#16906
Merged
mzikherman merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
#7096 Bundle Size — 8.66MiB (+0.03%).9374cc0(current) vs 9234a95 main#7093(baseline) Warning Bundle contains 31 duplicate packages – View duplicate packages Bundle metrics
|
| Current #7096 |
Baseline #7093 |
|
|---|---|---|
 Initial JS |
2.84MiB(+0.09%) |
2.84MiB |
 Initial CSS |
0B |
0B |
| Cache Invalidation |
19.5% |
19.5% |
| Chunks |
110 |
110 |
| Assets |
113 |
113 |
 Modules |
5522(+0.04%) |
5520 |
| Duplicate Modules |
618 |
618 |
| Duplicate Code |
4.93% |
4.93% |
| Packages |
250 |
250 |
| Duplicate Packages |
30 |
30 |
Bundle size by type 1 change 1 regression
| Current #7096 |
Baseline #7093 |
|
|---|---|---|
| JS |
8.51MiB (+0.03%) |
8.51MiB |
| Other |
152.75KiB |
152.75KiB |
Bundle analysis report Branch revert-16905-revert-16897-conten... Project dashboard
Generated by RelativeCI Documentation Report issue
starsirius
reviewed
Mar 6, 2026
| // Skip Found Redirect instances — spreading them into plain objects | ||
| // destroys their prototype `render()` method, breaking the redirect. | ||
| if (route instanceof Redirect) { | ||
| return route |
Contributor
Author
|
Re-trying this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting the revert, + a commit to fix the issue!
Everything from #16897 is re-instated!