Skip to content

Revert "chore: undo SSR flags"#16881

Open
ansor4 wants to merge 1 commit intomainfrom
revert-16359-revert-to-good-state
Open

Revert "chore: undo SSR flags"#16881
ansor4 wants to merge 1 commit intomainfrom
revert-16359-revert-to-good-state

Conversation

@ansor4
Copy link
Member

@ansor4 ansor4 commented Mar 3, 2026

Reverts #16359

Fixes EMI-3059

Looks like this is what needs to happen in order to fix the unawaited Unleash promise that we're running into with the ticket.

@damassi's comment seems to express confidence that this change is fine to re-revert now, we can keep an eye on the integrity with some time on our side.

TODO:

  • Once this is in, we can undo the changes in this PR.

@ansor4 ansor4 self-assigned this Mar 3, 2026
@ansor4 ansor4 force-pushed the revert-16359-revert-to-good-state branch from 3365623 to 6f75f2b Compare March 5, 2026 19:28
@artsyit
Copy link
Contributor

artsyit commented Mar 5, 2026

New dependencies added: @types/loadable__webpack-plugin and @types/webpack-node-externals.

@types/loadable__webpack-plugin

Used in package.json
Author: Unknown Description: TypeScript definitions for @loadable/webpack-plugin
License: MIT Homepage: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/loadable__webpack-plugin
Updated: 4 months ago Created: over 6 years ago
Releases: 9 Maintainers: 1
README

[object Object]

@types/webpack-node-externals

Used in package.json
Author: Unknown Description: TypeScript definitions for webpack-node-externals
License: MIT Homepage: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/webpack-node-externals
Updated: 7 months ago Created: over 8 years ago
Releases: 15 Maintainers: 1
README

[object Object]

Generated by 🚫 dangerJS against bd8a257

@relativeci
Copy link

relativeci bot commented Mar 5, 2026

#7050 Bundle Size — 8.66MiB (+0.01%).

bd8a257(current) vs 3dae401 main#7048(baseline)

Warning

Bundle contains 31 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 2 regressions
                 Current
#7050
     Baseline
#7048
Regression  Initial JS 2.84MiB(+0.01%) 2.84MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 44.92% 24.21%
No change  Chunks 110 110
No change  Assets 113 113
Change  Modules 5526(+0.09%) 5521
Regression  Duplicate Modules 621(+0.49%) 618
Change  Duplicate Code 4.94%(+0.2%) 4.93%
No change  Packages 250 250
No change  Duplicate Packages 30 30
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#7050
     Baseline
#7048
Regression  JS 8.51MiB (+0.01%) 8.51MiB
Improvement  Other 152.72KiB (-0.02%) 152.75KiB

Bundle analysis reportBranch revert-16359-revert-to-good-stat...Project dashboard


Generated by RelativeCIDocumentationReport issue

@ansor4 ansor4 force-pushed the revert-16359-revert-to-good-state branch from 6f75f2b to bd8a257 Compare March 5, 2026 21:05
@dzucconi
Copy link
Member

dzucconi commented Mar 6, 2026

I pulled this down locally and useVariant is still only operating client-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants