refactor(deprecation): replace moment with luxon by gkartalis · Pull Request #13207 · artsy/eigen

gkartalis · 2026-01-30T15:59:42Z

This PR resolves []

Description

Completely removes moment and moment-timezone and replaces them with luxon.

Migration was performed along with Claude so please review carefully.

Followups:

thorough code review
test out functionality

PR Checklist

I have tested my changes on the following platforms:
- Android.
- iOS.
I hid my changes behind a feature flag, or they don't need one.
I have included screenshots or videos at least on Android, or I have not changed the UI.
I have added tests, or my changes don't require any.
I added an app state migration, or my changes do not require one.
I have documented any follow-up work that this PR will require, or it does not require any.
I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

replace moment with luxon

Need help with something? Have a look at our docs, or get in touch with us.

MounirDhahri

finally happened 😄 😄 😄

gkartalis · 2026-01-30T16:01:35Z

@MounirDhahri yessss but we need to carefully review this PR in case claude missed any spots haha

MounirDhahri

Here is the output of me asking Opus to review this

Issues to Address

Test Behavior Change (AuctionResultListItem.tests.tsx:223-225)

expect(navigate).not.toHaveBeenCalled()

expect(navigate).toHaveBeenCalled()
This test assertion was inverted. The original test expected that when onPress is specified, navigate should NOT be called. The
new test expects the opposite. This appears unrelated to the moment→luxon migration and needs verification.

Ordinal Date Format Loss (TimeSince.tsx:22)

return date.format("ddd, MMM Do, h:mm A")

return date.toFormat("EEE, MMM d, h:mm A")
Moment's Do produces ordinal numbers ("1st", "2nd", "3rd") while Luxon's d produces plain numbers ("1", "2", "3"). This changes
output from "Wed, Jan 1st, 3:30 PM" to "Wed, Jan 1, 3:30 PM". If ordinals are desired, you'll need a custom helper.

Describe Block Mistakenly Converted to it (Timer.tests.tsx:170)

describe("displays the minutes when the sale does not end on the hour", () => {

it("displays the minutes when the sale does not end on the hour", () => {
A describe block was changed to an it block. This removes the grouping structure. If intentional, the block body should be
reviewed for nested tests.

Potential Null Timezone (Timer.tsx:119)

const userZone = DateTime.local().zoneName
zoneName can return null in rare edge cases. Consider:
const userZone = DateTime.local().zoneName ?? "UTC"

Files Needing Extra Attention

src/app/Components/Lists/tests/AuctionResultListItem.tests.tsx - behavior change
src/app/Scenes/Inbox/Components/Conversations/TimeSince.tsx - ordinal format change
src/app/Components/Bidding/Components/tests/Timer.tests.tsx - describe→it change
src/app/utils/saleTime.ts - complex timezone logic, highest risk

src/app/Components/Lists/__tests__/AuctionResultListItem.tests.tsx

MounirDhahri · 2026-01-30T16:13:00Z

I reviewed Claude's output, and it seems to be valid in this case

gkartalis · 2026-01-30T16:14:30Z

fixing the tests and will review afterwards

github-actions · 2026-02-03T09:23:07Z

🎉 Beta Versions Generated (commit: `a639097`)

Android 🤖

8.93.0 (2026020309) - Available on Play Store
8.93.0 (2026020309) - Available on Firebase

iOS 🍏

8.93.0 (2026.02.03.09) - Available on TestFlight
8.93.0 (2026.02.03.09) - Available on Firebase

MrSltun

Thank you for this change, finally!!
I left a few comments, but other than that it looks great! 🌟

src/app/utils/useEventTiming.tsx

src/app/utils/saleTime.ts

src/app/utils/__tests__/saleTime.tests.ts

MrSltun · 2026-02-11T12:11:22Z

src/app/Scenes/SaleInfo/SaleInfo.tsx

+      .toFormat("h:mma ZZZZ")
+      .replace("AM", "am")
+      .replace("PM", "pm")


Suggestion: I see that this is being used in multiple places. Should we move it to a util file?

MrSltun · 2026-02-11T12:12:25Z

src/app/Scenes/Sale/__tests__/SaleHeader.tests.tsx


      describe("absolute date label", () => {
-        it("shows the start date if the sale has not started", () => {
+        it("shows the start date if the sale has not started", async () => {


github-actions · 2026-03-02T14:28:08Z

🎉 Beta Versions Generated (commit: `66c59eb`)

iOS 🍏

9.0.0 (2026.03.02.14) - Available on Firebase

Android 🤖

9.0.0 (2026030214) - Available on Firebase
9.0.0 (2026030214) - Available on Play Store

Replace all moment.js and moment-timezone usage with Luxon equivalents: - Update test infrastructure to support Luxon timezone mocking - Migrate duration components to use Luxon Duration API - Convert complex timezone conversion logic in saleTime.ts - Update timer and countdown components - Migrate date formatting, comparisons, and arithmetic operations - Remove moment.js and moment-timezone dependencies Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

gkartalis · 2026-03-03T13:11:08Z

src/app/Components/ArtworkGrids/LotProgressBar.tsx

-    hours: duration.hours(),
-    minutes: duration.minutes(),
-    seconds: duration.seconds(),
+    days: duration.as("days"),


Before After

gkartalis · 2026-03-03T13:18:42Z

src/app/Scenes/AuctionResult/AuctionResult.tsx

@@ -254,9 +259,13 @@ export const AuctionResult: React.FC<Props> = (props) => {
            <Text variant="sm-display">{auctionResult.title}</Text>
            <Text variant="xs" color="mono60" my={0.5}>
              {[
-                moment(auctionResult.saleDate).utc().format("MMM D, YYYY"),
+                auctionResult.saleDate
+                  ? DateTime.fromISO(auctionResult.saleDate).toUTC().toFormat("MMM d, yyyy")
+                  : "",
                auctionResult.organization,
-              ].join(" • ")}
+              ]
+                .filter(Boolean)
+                .join(" • ")}


Before After

gkartalis · 2026-03-03T13:31:18Z

src/app/utils/useEventTiming.tsx

+    DateTime.fromISO(endAt).diff(DateTime.fromISO(currentTime)).toISO() || "PT0S"
  )
  const daysTilEnd = durationTilEnd.as("days")
  const hoursTillEnd = durationTilEnd.as("hours")
  const secondsTilEnd = durationTilEnd.as("seconds")

  const hasStarted =
-    Duration.fromISO(DateTime.fromISO(startAt).diff(DateTime.fromISO(currentTime)).toString())
-      .seconds < 0
+    Duration.fromISO(
+      DateTime.fromISO(startAt).diff(DateTime.fromISO(currentTime)).toISO() || "PT0S"
+    ).seconds < 0


Before After

src/app/utils/saleTime.ts

ArtsyOpenSource · 2026-03-11T11:10:41Z

This PR contains the following changes:

Dev changes (replace moment with luxon - gkartalis)

Generated by 🚫 dangerJS against 0ba7fba

This reverts commit 6584717.

gkartalis self-assigned this Jan 30, 2026

gkartalis requested review from MounirDhahri, MrSltun and brainbicycle and removed request for MounirDhahri January 30, 2026 15:59

gkartalis added the FF label Jan 30, 2026

MounirDhahri reviewed Jan 30, 2026

View reviewed changes

MounirDhahri previously approved these changes Jan 30, 2026

View reviewed changes

MounirDhahri reviewed Jan 30, 2026

View reviewed changes

src/app/Components/Lists/__tests__/AuctionResultListItem.tests.tsx Show resolved Hide resolved

gkartalis marked this pull request as draft January 30, 2026 16:46

gkartalis dismissed MounirDhahri’s stale review via 18fd4a5 January 30, 2026 17:00

artsy deleted a comment from ArtsyOpenSource Jan 30, 2026

gkartalis marked this pull request as ready for review February 9, 2026 16:56

MrSltun previously approved these changes Feb 11, 2026

View reviewed changes

gkartalis dismissed MrSltun’s stale review via 641f867 February 13, 2026 10:29

gkartalis force-pushed the gkartalis/replace-moment-with-luxon branch from a639097 to 641f867 Compare February 13, 2026 10:29

artsy deleted a comment from ArtsyOpenSource Feb 13, 2026

gkartalis force-pushed the gkartalis/replace-moment-with-luxon branch from 1dc8e67 to 8fb7641 Compare March 2, 2026 13:41

artsy deleted a comment from ArtsyOpenSource Mar 2, 2026

gkartalis and others added 4 commits March 10, 2026 17:43

build(deps): bump luxon to latest

8a1dcd7

fix: tests

fe27a03

refactor: remove userTimeZone parameter from saleTime functions

9607b58

comment out tests for now

66a0cfa

gkartalis force-pushed the gkartalis/replace-moment-with-luxon branch from 66c59eb to 66a0cfa Compare March 10, 2026 16:58

artsy deleted a comment from ArtsyOpenSource Mar 10, 2026

uncomment tests

9a40548

artsy deleted a comment from ArtsyOpenSource Mar 11, 2026

gkartalis commented Mar 11, 2026

View reviewed changes

fix: tests

0ba7fba

artsy deleted a comment from ArtsyOpenSource Mar 11, 2026

gkartalis merged commit 6584717 into main Mar 12, 2026
9 checks passed

gkartalis deleted the gkartalis/replace-moment-with-luxon branch March 12, 2026 08:34

gkartalis added a commit that referenced this pull request Mar 12, 2026

Revert "refactor(deprecation): replace moment with luxon (#13207)"

32916f6

This reverts commit 6584717.

gkartalis mentioned this pull request Mar 12, 2026

refactor(Revert): Revert "refactor(deprecation): replace moment with luxon" #13353

Merged

Conversation

gkartalis commented Jan 30, 2026

Description

Followups:

PR Checklist

To the reviewers 👀

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Uh oh!

MounirDhahri left a comment

Choose a reason for hiding this comment

Uh oh!

gkartalis commented Jan 30, 2026

Uh oh!

MounirDhahri left a comment

Choose a reason for hiding this comment

Issues to Address

Files Needing Extra Attention

Uh oh!

Uh oh!

MounirDhahri commented Jan 30, 2026

Uh oh!

gkartalis commented Jan 30, 2026

Uh oh!

github-actions bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Beta Versions Generated (commit: a639097)

Android 🤖

iOS 🍏

Uh oh!

MrSltun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrSltun Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

MrSltun Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Beta Versions Generated (commit: 66c59eb)

iOS 🍏

Android 🤖

Uh oh!

gkartalis Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

gkartalis Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

gkartalis Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ArtsyOpenSource commented Mar 11, 2026

This PR contains the following changes:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Feb 3, 2026 •

edited

Loading

🎉 Beta Versions Generated (commit: `a639097`)

github-actions bot commented Mar 2, 2026 •

edited

Loading

🎉 Beta Versions Generated (commit: `66c59eb`)