ci: Fix ignored.yml and update FFI tests#326
Merged
samuelburnham merged 3 commits intomainfrom Mar 11, 2026
Merged
Conversation
samuelburnham
force-pushed
the
ci-ignored
branch
from
fe36a1b to
9c76a9d
Compare
Ix/Ixon.lean
Outdated
Comment on lines
+1828
to
+1829
| @[extern "rs_des_env"] | ||
| opaque rsDesEnvFFI : @& ByteArray → Except String RawEnv | ||
| opaque rsDeEnvFFI : @& ByteArray → Except String RawEnv |
Member
There was a problem hiding this comment.
The Lean function was renamed, but the Rust function remains the same. We should either not change any or change both of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignored-testCI job due to alean-actionbug, which will be fixed in fix: Settest-argsinput correctly and improve functional tests leanprover/lean-action#153.ffitest suite, as we are trusting Lean itself to be leak-free and only need to test our Rust FFI boundary. Running the full suite is also expensive at 30+ minutes per CI run due to Valgrind overhead.Successful run: https://github.com/argumentcomputer/ix/actions/runs/22956912799