refactor: consolidate and enhance unit tests for subnet and pool stat… #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reoring
commented
May 13, 2025
reoring
commented
- Removed the obsolete mapper_test.go file and replaced it with new tests in subnet_mapper_test.go and poolstatus_mapper_test.go.
- Added comprehensive test cases for the mapSubnetToParentPool and mapAllocToPool functions, ensuring proper handling of PoolRef and namespace validations.
- Introduced additional tests for duplicate request suppression in workqueue_dedupe_test.go, verifying the behavior of the workqueue under various conditions.
…us mappers - Removed the obsolete mapper_test.go file and replaced it with new tests in subnet_mapper_test.go and poolstatus_mapper_test.go. - Added comprehensive test cases for the mapSubnetToParentPool and mapAllocToPool functions, ensuring proper handling of PoolRef and namespace validations. - Introduced additional tests for duplicate request suppression in workqueue_dedupe_test.go, verifying the behavior of the workqueue under various conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.