Skip to content

refactor: implement private scheme for test environments to prevent r…#2

Merged
reoring merged 2 commits intomainfrom
fix-ci-flaky
May 13, 2025
Merged

refactor: implement private scheme for test environments to prevent r…#2
reoring merged 2 commits intomainfrom
fix-ci-flaky

Conversation

@reoring
Copy link
Contributor

@reoring reoring commented May 13, 2025

race conditions

  • Updated test environment setup functions to create and use a private scheme, ensuring thread safety during concurrent test execution.
  • Modified client and manager creation functions to accept the private scheme, enhancing isolation in tests.
  • Removed redundant scheme registration calls, as types are now registered in the private scheme.
  • Introduced a new helper function, NewTestScheme, to streamline scheme creation for tests.

reoring added 2 commits May 13, 2025 10:51
…ace conditions

- Updated test environment setup functions to create and use a private scheme, ensuring thread safety during concurrent test execution.
- Modified client and manager creation functions to accept the private scheme, enhancing isolation in tests.
- Removed redundant scheme registration calls, as types are now registered in the private scheme.
- Introduced a new helper function, NewTestScheme, to streamline scheme creation for tests.
- Replaced direct scheme creation and registration in multiple test files with a common helper function, NewTestScheme, to enhance code reuse and maintainability.
- This change simplifies the setup process for test environments, ensuring consistent scheme configuration across tests while preventing race conditions.
@reoring reoring merged commit 9998a24 into main May 13, 2025
6 checks passed
@reoring reoring deleted the fix-ci-flaky branch May 13, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant