! B don't require optional com.google.gson package#769
Draft
! B don't require optional com.google.gson package#769
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideGeneralizes JsonApprovals’ Gson-related overloads to avoid a hard dependency on com.google.gson, while preserving behavior via generics and casts, and updates tests and documentation metadata accordingly. Class diagram for generalized JsonApprovals Gson overloadsclassDiagram
class JsonApprovals {
+static void verifyJson(String json, boolean reorderJson)
+static void verifyJson(String json, boolean reorderJson, Options options)
+static <T> void verifyJson(String json, boolean reorderJson, Function1Generic gsonBuilder)
+static <T> void verifyJson(String json, boolean reorderJson, Function1Generic gsonBuilder, Options options)
+static void verifyAsJson(Object o)
+static void verifyAsJson(Object o, Options options)
+static <T> void verifyAsJson(Object o, Function1Generic gsonBuilder)
+static <T> void verifyAsJson(Object o, Function1Generic gsonBuilder, Options options)
}
class JsonUtils {
+static String reorderFields(String json, Function1Generic gsonBuilder)
+static String prettyPrint(String json, Function1Generic gsonBuilder)
+static String asJson(Object o, Function1Generic gsonBuilder)
}
class Approvals {
+static void verify(String formattedJson, Options options)
}
class Options {
+Options forFile()
+Options withExtension(String extension)
}
class Function1Generic {
+TOut apply(TIn input)
}
JsonApprovals ..> JsonUtils
JsonApprovals ..> Approvals
JsonApprovals ..> Options
JsonApprovals ..> Function1Generic
JsonUtils ..> Function1Generic
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #768
Summary by Sourcery
Relax JsonApprovals’ dependency on Gson by generalizing its builder callbacks, while keeping existing behavior intact.
Enhancements:
Tests: