Skip to content

[BANK-1738] Update supported Ruby versions to 3.3.10, 3.4.8, 4.0.1 #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maimer merged 1 commit into from
Mar 6, 2026
Merged

[BANK-1738] Update supported Ruby versions to 3.3.10, 3.4.8, 4.0.1 #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ workflows:
matrix:
parameters:
ruby_version:
- '3.4.1'
- '3.3.6'
- '3.2.5'
- '4.0.1'
- '3.4.8'
- '3.3.10'
after-checkout-steps:
- install_dependencies
after-appraisal-install-steps:
Expand All @@ -73,9 +73,9 @@ workflows:
matrix:
parameters:
ruby_version:
- '3.4.1'
- '3.3.6'
- '3.2.5'
- '4.0.1'
- '3.4.8'
- '3.3.10'
after-checkout-steps:
- install_dependencies
after-appraisal-install-steps:
Expand All @@ -92,9 +92,9 @@ workflows:
matrix:
parameters:
ruby_version:
- '3.4.1'
- '3.3.6'
- '3.2.5'
- '4.0.1'
- '3.4.8'
- '3.3.10'
after-checkout-steps:
- install_dependencies
after-appraisal-install-steps:
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ruby-3.4.1
ruby-4.0.1
3 changes: 1 addition & 2 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

case RUBY_VERSION
when '3.2.5', '3.3.6', '3.4.1'
if Gem::Requirement.new(['>= 3.3', '< 4.1']).satisfied_by?(Gem::Version.new(RUBY_VERSION))
appraise "ruby-#{RUBY_VERSION}" do
end
else
Expand Down
6 changes: 3 additions & 3 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ source 'https://rubygems.org' # global source

source 'https://rubygems.org' do
gem 'appraisal', '>= 2.5', '< 3'
gem 'bundler', '>= 2.6', '< 3'
gem 'bundler', '>= 2.6', '< 5'
gem 'debug', '>= 1.11', '< 2'
gem 'mocha', '>= 2.7', '< 3'
gem 'pry', '>= 0.15', '< 1'
gem 'mocha', '>= 3', '< 4'
gem 'pry', '>= 0.16', '< 1'
gem 'rake', '>= 13.3', '< 14'
gem 'selenium-webdriver', '>= 4.38', '< 5'
gem 'simplecov', '>= 0.22', '< 1', group: :test, require: false
Expand Down
2 changes: 1 addition & 1 deletion LICENSE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (C) 2012-2025 AppFolio, inc.
Copyright (C) 2012-2026 AppFolio, inc.

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class SeleniumRunner
matrix = {}

Dir.glob(file_pattern).each do |file|
matches = file.match(%r{(test/test_apps/(\d\.\d))/gemfiles/(.*ruby_(\d\.\d\.\d)\.gemfile)})
matches = file.match(%r{(test/test_apps/(\d+\.\d+))/gemfiles/(.*ruby_(\d+\.\d+\.\d+)\.gemfile)})

gemfile_path = matches[0]
app_root = matches[1]
Expand Down
4 changes: 2 additions & 2 deletions ae_page_objects.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ Gem::Specification.new do |spec|
spec.summary = spec.description
spec.homepage = 'https://github.com/appfolio/ae_page_objects'
spec.license = 'MIT'
spec.files = Dir['**/*'].select { |f| f[%r{^(lib/|LICENSE.txt|.*gemspec)}] }
spec.files = Dir['**/*'].select { |f| f[%r{^(lib/|LICENSE.txt|ae_page_objects\.gemspec)}] }
spec.require_paths = ['lib']

spec.required_ruby_version = Gem::Requirement.new('< 3.5')
spec.required_ruby_version = Gem::Requirement.new('< 4.1')
spec.metadata['allowed_push_host'] = 'https://rubygems.org'

spec.add_dependency('capybara', ['>= 3', '< 4'])
Expand Down
3 changes: 1 addition & 2 deletions test/test_apps/7.2/Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

case RUBY_VERSION
when '3.2.5', '3.3.6', '3.4.1'
if Gem::Requirement.new(['>= 3.3', '< 4.1']).satisfied_by?(Gem::Version.new(RUBY_VERSION))
appraise "ruby-#{RUBY_VERSION}" do
end
else
Expand Down
1 change: 1 addition & 0 deletions test/test_apps/7.2/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'minitest', '~> 5.0'
gem 'rails', '~> 7.2.0'
# Use sqlite3 as the database for Active Record
gem 'sqlite3', '~> 1.4'
Expand Down
1 change: 1 addition & 0 deletions ...test_apps/7.2/gemfiles/ruby_3.2.5.gemfile → ...est_apps/7.2/gemfiles/ruby_3.3.10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "minitest", "~> 5.0"
gem "rails", "~> 7.2.0"
gem "sqlite3", "~> 1.4"
gem "puma", ">= 5.6.8"
Expand Down
1 change: 1 addition & 0 deletions ...test_apps/7.2/gemfiles/ruby_3.3.6.gemfile → ...test_apps/7.2/gemfiles/ruby_3.4.8.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "minitest", "~> 5.0"
gem "rails", "~> 7.2.0"
gem "sqlite3", "~> 1.4"
gem "puma", ">= 5.6.8"
Expand Down
1 change: 1 addition & 0 deletions ...test_apps/7.2/gemfiles/ruby_3.4.1.gemfile → ...test_apps/7.2/gemfiles/ruby_4.0.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "minitest", "~> 5.0"
gem "rails", "~> 7.2.0"
gem "sqlite3", "~> 1.4"
gem "puma", ">= 5.6.8"
Expand Down
3 changes: 1 addition & 2 deletions test/test_apps/8.0/Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

case RUBY_VERSION
when '3.2.5', '3.3.6', '3.4.1'
if Gem::Requirement.new(['>= 3.3', '< 4.1']).satisfied_by?(Gem::Version.new(RUBY_VERSION))
appraise "ruby-#{RUBY_VERSION}" do
end
else
Expand Down
1 change: 1 addition & 0 deletions test/test_apps/8.0/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'minitest', '~> 5.0'
gem 'rails', '~> 8.0.0'
# Use sqlite3 as the database for Active Record
gem 'sqlite3', '~> 2.1'
Expand Down
1 change: 1 addition & 0 deletions ...test_apps/8.0/gemfiles/ruby_3.3.6.gemfile → ...est_apps/8.0/gemfiles/ruby_3.3.10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "minitest", "~> 5.0"
gem "rails", "~> 8.0.0"
gem "sqlite3", "~> 2.1"
gem "puma", ">= 5.6.8"
Expand Down
1 change: 1 addition & 0 deletions ...test_apps/8.0/gemfiles/ruby_3.4.1.gemfile → ...test_apps/8.0/gemfiles/ruby_3.4.8.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "minitest", "~> 5.0"
gem "rails", "~> 8.0.0"
gem "sqlite3", "~> 2.1"
gem "puma", ">= 5.6.8"
Expand Down
1 change: 1 addition & 0 deletions ...test_apps/8.0/gemfiles/ruby_3.2.5.gemfile → ...test_apps/8.0/gemfiles/ruby_4.0.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "minitest", "~> 5.0"
gem "rails", "~> 8.0.0"
gem "sqlite3", "~> 2.1"
gem "puma", ">= 5.6.8"
Expand Down
3 changes: 1 addition & 2 deletions test/test_apps/8.1/Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

case RUBY_VERSION
when '3.2.5', '3.3.6', '3.4.1'
if Gem::Requirement.new(['>= 3.3', '< 4.1']).satisfied_by?(Gem::Version.new(RUBY_VERSION))
appraise "ruby-#{RUBY_VERSION}" do
end
else
Expand Down
0 ...test_apps/8.1/gemfiles/ruby_3.2.5.gemfile → ...est_apps/8.1/gemfiles/ruby_3.3.10.gemfile
View file
Open in desktop
File renamed without changes.
0 ...test_apps/8.1/gemfiles/ruby_3.3.6.gemfile → ...test_apps/8.1/gemfiles/ruby_3.4.8.gemfile
View file
Open in desktop
File renamed without changes.
0 ...test_apps/8.1/gemfiles/ruby_3.4.1.gemfile → ...test_apps/8.1/gemfiles/ruby_4.0.1.gemfile
View file
Open in desktop
File renamed without changes.
Loading