[SYSTEMDS-3421] Add serialization support for UDF encoders#2397
Open
zohrehasadi00 wants to merge 2 commits intoapache:mainfrom
Open
[SYSTEMDS-3421] Add serialization support for UDF encoders#2397zohrehasadi00 wants to merge 2 commits intoapache:mainfrom
zohrehasadi00 wants to merge 2 commits intoapache:mainfrom
Conversation
Signed-off-by: Zohreh <zohrehasadi2018@yahoo.com>
Signed-off-by: Zohreh <zohrehasadi2018@yahoo.com>
Contributor
Author
|
@janniklinde This is my first time contributing to an open-source project voluntarily. Should I do anything from my side, or will someone review the PR automatically through the queue or sth? tnx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds UDF encoder type to ColumnEncoder enum and EncoderFactory -> UDF encoders can be created/serialized.
Implements readExternal/writeExternal for ColumnEncoderUDF to persist function name and domain size.
Adds a regression test.