Skip to content

chore: Update MSRV to 1.91.0#2204

Merged
blackmwk merged 1 commit intoapache:mainfrom
xanderbailey:xb/msrv_1.91.0
Mar 5, 2026
Merged

chore: Update MSRV to 1.91.0#2204
blackmwk merged 1 commit intoapache:mainfrom
xanderbailey:xb/msrv_1.91.0

Conversation

@xanderbailey
Copy link
Contributor

@xanderbailey xanderbailey commented Mar 3, 2026

Which issue does this PR close?

#2199 requires a bump to MSRV 1.91.0. This version is within the policy of this project.

  • Closes #.

What changes are included in this PR?

Are these changes tested?

Copy link
Collaborator

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xanderbailey!

@blackmwk
Copy link
Contributor

blackmwk commented Mar 4, 2026

Hi, @xanderbailey Following our discussion, our policy is to update msrv when relaseon a new version: https://github.com/apache/iceberg-rust?tab=readme-ov-file#supported-rust-version

@blackmwk
Copy link
Contributor

blackmwk commented Mar 4, 2026

We have a monthly release schedule plan, so we hope to release a new version soon

@xanderbailey
Copy link
Contributor Author

Thanks, just so I understand correctly, is the plan always to bump MSRV after we release or before?

Because currently we're depending on a version of datafusion that has known bugs and correctness issues so releasing with 52.1 as a dependency would likely mean people would need to skip the 0.9.0 release.

@mbutrovich
Copy link
Collaborator

Thanks, just so I understand correctly, is the plan always to bump MSRV after we release or before?

Because currently we're depending on a version of datafusion that has known bugs and correctness issues so releasing with 52.1 as a dependency would likely mean people would need to skip the 0.9.0 release.

Last time we bumped MSRV just before the 0.8.0 release, so it was included in that. IIRC 0.8.0 and a DataFusion bump went in just before 0.8.0. I'm gonna start testing DF53 with iceberg-rust today as well (not released yet).

@blackmwk
Copy link
Contributor

blackmwk commented Mar 5, 2026

Thanks, just so I understand correctly, is the plan always to bump MSRV after we release or before?

Because currently we're depending on a version of datafusion that has known bugs and correctness issues so releasing with 52.1 as a dependency would likely mean people would need to skip the 0.9.0 release.

We usually bump it before the release. In this case I think it would be reasonable to bump it now, thanks for the explaination.

Copy link
Contributor

@blackmwk blackmwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xanderbailey for this fix!

@blackmwk blackmwk merged commit c720895 into apache:main Mar 5, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants