feat: check schema capability when adding parquet files#2158
Open
charlesdong1991 wants to merge 1 commit intoapache:mainfrom
Open
feat: check schema capability when adding parquet files#2158charlesdong1991 wants to merge 1 commit intoapache:mainfrom
charlesdong1991 wants to merge 1 commit intoapache:mainfrom
Conversation
kevinjqliu
force-pushed
the
feat/schema-compat-check
branch
from
0141cdc to
354d9b5
Compare
jdockerty
reviewed
Mar 5, 2026
Contributor
jdockerty
left a comment
jdockerty
left a comment
There was a problem hiding this comment.
This looks quite reasonable to me 👍
Comment on lines
+437
to
+438
| /// in the file schema (looked up by field ID). Follows the same semantics as | ||
| /// iceberg-python's `_check_schema_compatible`. |
Contributor
There was a problem hiding this comment.
I'm not sure how likely it is that this method name would change, but it is perhaps worth linking to the specific commit that you've referenced this from?
That way the details are clear from looking at the reference implementation.
| /// Returns `true` if `self` can be promoted to `target` per the Iceberg spec's | ||
| /// valid type promotion rules. | ||
| /// | ||
| /// See <https://iceberg.apache.org/spec/#schema-evolution> |
Comment on lines
+328
to
+329
| .map(|s| serde_json::from_str::<NameMapping>(s)) | ||
| .transpose() |
Contributor
There was a problem hiding this comment.
Is this transpose usage required?
If I'm understanding this rightly, it is being used to flip the map output on Err (after from_str) for the map_err to bubble up afterwards.
Although it seems like some indirection when a match would be more explicit/easy to follow too.
This may just be a preference thing though, feel free to disregard 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Adds schema compatibility validation when converting existing parquet files to data files
via
parquet_files_to_data_files.Are these changes tested?
Yes, tests are passing locally