Fix: make test-coverage to properly enable coverage for all test suites #2989
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
test-coveragetarget was failing with "No data to combine" because theCOVERAGE=1variable wasn't being propagated to prerequisite test targets.Make's target-specific variable syntax (
test-coverage: COVERAGE=1) only sets the variable for that specific target, not for its prerequisites when they execute as separate Make invocations.Found this out when verifying release, which is the only place we run
make test-coverage. CI runsmake coverage-reportAre these changes tested?
Ran
make test-coveragebefore and afterAre there any user-facing changes?