Skip to content

Conversation

@geruh
Copy link
Contributor

@geruh geruh commented Jan 30, 2026

Rationale for this change

Include uv.lock in sdist so dependency resolution matches the release branch.

Are these changes tested?

Yes

> cd /tmp/test-install2/pyiceberg-0.11.0 && uv pip list | grep -i "pytz\|pandas"
pandas                        2.3.3
pytz                          2025.2

> make test
tests/utils/test_singleton.py::test_singleton PASSED                     [ 99%]
tests/utils/test_singleton.py::test_singleton_transform PASSED           [ 99%]
tests/utils/test_truncate.py::test_upper_bound_string_truncation PASSED  [ 99%]
tests/utils/test_truncate.py::test_upper_bound_binary_truncation PASSED  [100%]
=============== 3505 passed, 1481 deselected in 68.44s (0:01:08) ===============

Are there any user-facing changes?

No

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

this should be included. we added poetry.lock in #2405 for the same reason.

i guess this was missed during the uv migration, #2601 (review)
i dont see uv.lock in the "new" section

@Fokko
Copy link
Contributor

Fokko commented Jan 30, 2026

I think this is reasonable, but would there be a way to include a ASF 2.0 license? Otherwise we might need to add an exclusion to the license checker.

@kevinjqliu
Copy link
Contributor

we already have uv.lock in the rat exclude

@kevinjqliu kevinjqliu merged commit d770166 into apache:main Jan 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants