Skip to content

doc: add comment for historical package names#2970

Open
imbajin wants to merge 2 commits intomasterfrom
tiny
Open

doc: add comment for historical package names#2970
imbajin wants to merge 2 commits intomasterfrom
tiny

Conversation

@imbajin
Copy link
Member

@imbajin imbajin commented Mar 16, 2026

Add notes to README, hugegraph-store/README, and hugegraph-store/docs/deployment-guide indicating that historical releases (<= 1.7.0) used the "-incubating" suffix in package and directory names.

Add notes to README, hugegraph-store/README, and hugegraph-store/docs/deployment-guide indicating that historical releases (<= 1.7.0) used the "-incubating" suffix in package and directory names.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation to clarify that some historical HugeGraph releases used -incubating in distribution package/directory names, aiming to reduce confusion when following install/deploy instructions.

Changes:

  • Add a -incubating naming note to the root binary download instructions.
  • Add a similar note to HugeGraph Store’s quickstart run instructions.
  • Add similar notes to the Store deployment guide for PD/Store/Server extraction steps.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
README.md Adds a note about -incubating naming for historical binary packages.
hugegraph-store/README.md Adds a note about -incubating naming for historical Store directories.
hugegraph-store/docs/deployment-guide.md Adds -incubating naming notes to PD/Store/Server extraction steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added note points readers at the historical naming change, but hugegraph-store/docs/deployment-guide.md still hardcodes 1.7.0 commands without the -incubating segment. In tag 1.7.0, the documented commands were apache-hugegraph-pd-incubating-1.7.0, apache-hugegraph-store-incubating-1.7.0, and apache-hugegraph-incubating-1.7.0 (matching the 1.7.0 docs and module final.name settings). Because the guide uses concrete 1.7.0 examples, copy-pasting the current commands will still fail. Please either update those sample commands to the actual 1.7.0 names or switch the examples to a non-incubating release.

- update 1.7.0 command examples to use historical incubating package names
- clarify current vs historical download and directory naming in docs
- fix store README build path to use hg-store-dist
- replace hardcoded 1.7.0 paths with version placeholders where appropriate
@imbajin imbajin requested review from VGalaxies and Copilot March 16, 2026 13:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation to clarify that historical HugeGraph releases (<= 1.7.0) used the -incubating suffix in package and directory names, and adjusts example commands/paths accordingly.

Changes:

  • Add “historical -incubating suffix” notes to multiple guides (deployment/operations/development).
  • Update example tarball/directory names for 1.7.0 to include -incubating.
  • Adjust some build/distribution path examples to use version placeholders.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
hugegraph-store/docs/operations-guide.md Updates upgrade/rollback examples for 1.7.0 to use -incubating package/directory names.
hugegraph-store/docs/development-guide.md Replaces hardcoded 1.7.0 working directory with version placeholder and notes -incubating for historical releases.
hugegraph-store/docs/deployment-guide.md Updates extract/cd examples for PD/Store/Server 1.7.0 to include -incubating and adds explanatory notes.
hugegraph-store/README.md Updates build module path and distribution path examples; adds note about -incubating for historical releases.
README.md Expands download snippet to document archive URL and PACKAGE naming for historical -incubating releases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 104 to +107
mvn install -pl hugegraph-struct -am -DskipTests

# Build Store and all dependencies
mvn clean package -pl hugegraph-store/hugegraph-store-dist -am -DskipTests
mvn clean package -pl hugegraph-store/hg-store-dist -am -DskipTests
# Follow deployment guide
tar -xzf apache-hugegraph-store-1.7.0.tar.gz
cd apache-hugegraph-store-1.7.0
# Historical 1.7.0 packages still include the "-incubating" suffix
Comment on lines +234 to +236
wget ${BASE_URL}/${PACKAGE}.tar.gz
tar -xzf ${PACKAGE}.tar.gz
cd ${PACKAGE}
- Main class: `org.apache.hugegraph.store.node.StoreNodeApplication`
- VM options: `-Xms4g -Xmx4g -Dconfig.file=conf/application.yml`
- Working directory: `hugegraph-store/apache-hugegraph-store-1.7.0`
- Working directory: `hugegraph-store/apache-hugegraph-store-<version>` (`apache-hugegraph-store-incubating-<version>` for historical 1.7.0 and earlier directories)
Copy link
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up looks good. The historical 1.7.0 package and directory examples now match the actual release artifacts, and the README/store docs are aligned with the current packaging layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants