Update rustflags for target configurations#60
Open
binary-signal wants to merge 1 commit intoapache:mainfrom
Open
Update rustflags for target configurations#60binary-signal wants to merge 1 commit intoapache:mainfrom
binary-signal wants to merge 1 commit intoapache:mainfrom
Conversation
add targets for linux windows and apple
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
Hope you don't mind me reviewing this.
Can you include testing details if on the PR description if any?
Or alternatively, if this follows convention, would be helpful to point out where this is retrieved from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add targets for linux windows and apple