chore: remove async for upsert/delete/append in python #280
Conversation
|
cc @fresh-borzoni I'm going to merge it. Free feel to add following pr if you find any comments. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Python type stubs to reflect the (now synchronous) queueing semantics for append/upsert/delete, aligning the Python binding API with the core changes described in PR #271.
Changes:
- Make
AppendWriter.append()synchronous and return aWriteResultHandle. - Make
UpsertWriter.upsert()/UpsertWriter.delete()synchronous and return aWriteResultHandle. - Add a
WriteResultHandletype stub with an asyncwait()method for per-record acknowledgment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Supported Types: | ||
| Currently supports primitive types only: | ||
| - Boolean, TinyInt, SmallInt, Int, BigInt (integers) |
There was a problem hiding this comment.
AppendWriter.write_arrow_batch is still typed as returning None in this stub, but the binding returns a WriteResultHandle (so callers can optionally await per-batch ack). Update the stub signature to return WriteResultHandle to match the actual API.
|
@luoyuxia Sure, sorry - I always forget about this file :) |
luoyuxia
force-pushed
the
fix-python-api
branch
from
0f6ddbf to
3315af8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Purpose
Linked issue: close #xxx
Follow pr for #271
Brief change log
remove
asyncand returnWriteResultHandlein append/upsert/delete method in python bindingTests
API and Format
Documentation