Skip to content

chore: python bindings cleanup and bit of refactor#264

Merged
luoyuxia merged 1 commit intoapache:mainfrom
fresh-borzoni:python-table-rs-cleanup
Feb 7, 2026
Merged

chore: python bindings cleanup and bit of refactor#264
luoyuxia merged 1 commit intoapache:mainfrom
fresh-borzoni:python-table-rs-cleanup

Conversation

@fresh-borzoni
Copy link
Contributor

Summary

Refactor LogScanner to use ScannerKind enum

Replace two Option<T> fields (inner, inner_batch) on LogScanner with a
single ScannerKind enum. The previous design allowed impossible states, both
fields None, or both Some — which required defensive if/else chains in
every method. The enum makes the active scanner variant explicit at the type
level.

@fresh-borzoni
Copy link
Contributor Author

@leekeiabstraction @luoyuxia PTAL 🙏

@luoyuxia luoyuxia merged commit 82f8bba into apache:main Feb 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants