feat: introduce list partitions in cpp binding#260
Merged
luoyuxia merged 1 commit intoapache:mainfrom Feb 6, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces support for listing partition information in the C++ bindings, addressing issue #259. It exposes the existing list_partition_infos functionality from the core Rust library through the C++ FFI layer, allowing C++ clients to query partition metadata (partition ID and name) for a given table.
Changes:
- Added FFI structures (
FfiPartitionInfo,FfiListPartitionInfosResult) and method signature for listing partition information - Implemented the Rust-side FFI function that calls the core admin client's
list_partition_infosmethod - Added C++ wrapper function
ListPartitionInfosin the Admin class that handles FFI conversions and error handling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bindings/cpp/src/lib.rs | Defines FFI structures for partition info and implements the Rust-side FFI bridge function that calls the core admin API |
| bindings/cpp/src/admin.cpp | Implements the C++ wrapper ListPartitionInfos method with proper error handling and type conversions |
| bindings/cpp/include/fluss.hpp | Declares the PartitionInfo struct and ListPartitionInfos public API method in the Admin class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #259
Brief change log
Tests
API and Format
Documentation