[plan] Extract ResourceCache and PythonResourceBridge from AgentPlan#548
Open
weiqingy wants to merge 1 commit intoapache:mainfrom
Open
[plan] Extract ResourceCache and PythonResourceBridge from AgentPlan#548weiqingy wants to merge 1 commit intoapache:mainfrom
weiqingy wants to merge 1 commit intoapache:mainfrom
Conversation
Collaborator
Author
|
Both CI failures are unrelated to our changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #547
Purpose of change
AgentPlan(624 lines) mixes plan definition, resource caching/resolution, Python bridge wiring, and serialization.This PR extracts two classes to separate concerns:
ResourceCache— lazy resource resolution, caching, and cleanup. Created by the operator inopen(), owned bythe operator lifecycle.
PythonResourceBridge— staticdiscoverPythonMCPResources()for Python MCP tool/prompt discovery. Calledduring operator init.
After extraction,
AgentPlanbecomes immutable after construction (~490 lines, down from 624). The removed publicmethods are
getResource(),close(), andsetPythonResourceAdapter().Tests
mvn test -pl plan— all plan module tests passmvn test -pl runtime— all runtime module tests pass./tools/lint.sh -c— formatting check passed./tools/ut.sh -j— full Java test suite passedAPI
Yes. Three public methods removed from
AgentPlan:getResource(String, ResourceType)— replaced byResourceCache.getResource()close()— replaced byResourceCache.close()setPythonResourceAdapter(PythonResourceAdapter)— replaced byPythonResourceBridge.discoverPythonMCPResources()Documentation
doc-neededdoc-not-neededdoc-included