Open
Conversation
Contributor
|
Thanks @rafafrdz! Kicking off CI. |
Member
|
This looks good so far @rafafrdz. CI shows all three On the compatibility side, I noticed that the PR doesn't distinguish between ANSI and legacy mode for invalid URL handling. DataFusion's |
Contributor
Author
|
Thanks for the suggestion @andygrove What I did:
I also registered |
- Resolve conflict in jni_api.rs: add ParseUrl/TryParseUrl registrations
alongside SparkSpace and SparkBitCount from upstream
- Update datafusion-spark dependency to 52.2.0 (via upstream Cargo.toml)
- Simplify CometParseUrl serde:
- Spark 3.5 path reads failOnError directly from ParseUrl.failOnError
(no reflection needed)
- Spark 4.0 Invoke path uses reflection only on ParseUrlEvaluator
- Remove dead 'invoke' branch from convertExpression; rename
entry point to convertFromInvoke for clarity
- Expand parse_url.sql test: add PATH/FILE/REF/AUTHORITY/USERINFO
queries, ftp URL row, and try_parse_url coverage
- Add CometStringExpressionSuite tests: REF/AUTHORITY/USERINFO parts,
ANSI mode (Spark 3.5), and a dedicated try_parse_url test
- Remove try_parse_url SQL queries: try_parse_url is a Comet-internal DataFusion function name used when serializing parse_url with failOnError=false. It is not a registered Spark SQL function and calling it directly via SQL raises UNRESOLVED_ROUTINE on any Spark version. The NULL-on-invalid-URL behaviour is covered by the 'parse_url with invalid URL in legacy mode' Scala test. - Replace ftp port 21 with 2121 in test URLs: the Rust url crate omits well-known default ports (ftp=21) when serialising authority(), while Java URI.getRawAuthority() preserves them verbatim. Using a non-default port avoids this pre-existing semantic gap and keeps the AUTHORITY test case meaningful on both Spark 3.5 and 4.0.
rafafrdz
force-pushed
the
feat/add-support-parse_url
branch
from
7c8a8d9 to
9d7720f
Compare
Use Expression directly instead of a generic type parameter T <: Expression. This eliminates the asInstanceOf cast in convertFromInvokeUnchecked and the unchecked method itself, since QueryPlanSerde can now call convertFromInvoke directly without existential type issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_urlby mappingParseUrlto the native scalar functionparse_urlin expression serde.parse_urlas supported.Why
This closes one of the missing DataFusion 50 migration functions from issue #2443
Part of #2443