Add autocomplete support for the instanceid parameter#162
Closed
bernardodemarco wants to merge 1 commit intoapache:mainfrom
Closed
Add autocomplete support for the instanceid parameter#162bernardodemarco wants to merge 1 commit intoapache:mainfrom
instanceid parameter#162bernardodemarco wants to merge 1 commit intoapache:mainfrom
Conversation
9 tasks
nvazquez
approved these changes
Jul 9, 2025
Contributor
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
LGTM - tested autocompletion with the new API introduced on: apache/cloudstack#11016
shwstppr
reviewed
Jul 24, 2025
Contributor
shwstppr
left a comment
shwstppr
left a comment
There was a problem hiding this comment.
code lgtm but a query on the PR apache/cloudstack#11016
Why name the param as instanceid and not virtualmachineid?
Member
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR apache/cloudstack#11016 introduces the
listConsoleSessionsAPI, which accepts theinstanceidparameter, that represents the ID of the VM associated with the console session.However, currently, Apache Cloudstack Cloudmonkey does not support autocomplete for this parameter. Therefore, this PR adds autocomplete support for it.
How Has This Been Tested?
listConsoleSessionsAPI and verified that Apache CloudStack Cloudmonkey is correctly autocompleting theinstanceidparameter