fix: wheel LICENSE should not reference examples-only MIT files#673
Conversation
|
@skrawcz @elijahbenizzy ready for review. |
pjfanning
left a comment
There was a problem hiding this comment.
This change is not correct.
We need to leave the source code LICENSE alone because the problem file with 3rd party license is in the source code.
What we need is a separate LICENSE file that gets added to the whl file during its build that omits the bit in source LICENSE about the file that we do not add to the whl.
…he#641) Keep source LICENSE intact (Apache 2.0 + MIT attribution for examples/deep-researcher) and create a separate LICENSE-wheel (Apache-only) that Flit injects into the .whl via license-files. The sdist continues to ship the full LICENSE as before.
edd1ad4 to
144057a
Compare
|
@pjfanning Ah, let me see if I got this right now. The source tree LICENSE must keep the MIT attribution because I've reworked the approach: the source Can you take another look and see if this is what you had in mind? |
The wheel was shipping a LICENSE that mentioned MIT-licensed files from
examples/deep-researcher, but those files only exist in the source
distribution. Moved the third-party attribution to a dedicated
THIRD-PARTY-LICENSES file included only in the sdist.
Closes #641
Changes
How I tested this
Notes
Per ASF policy, LICENSE must reflect what's actually in the distribution.
Checklist