Skip to content

fix: memory leak #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Varnill wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: memory leak #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/include/graphics/vulkan/ComputePipeline.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ class ComputePipeline : public IPipeline {
void init(VkDevice device) override;
void bind(VkCommandBuffer cmd) override;
void destroy() override;

~ComputePipeline() override {
ComputePipeline::destroy();
}
VkPipeline getPipeline() const override { return _pipeline; }
VkPipelineLayout getLayout() const override { return _pipelineLayout; }

Expand Down
9 changes: 9 additions & 0 deletions src/include/graphics/vulkan/vk_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ enum class MaterialPass : uint8_t { MainColor, Transparent, Other };
struct MaterialPipeline {
VkPipeline pipeline;
VkPipelineLayout layout;
VkDevice _device = VK_NULL_HANDLE;
~MaterialPipeline() {
if (_device != VK_NULL_HANDLE) {
vkDestroyPipelineLayout(_device, layout, nullptr);
vkDestroyPipeline(_device, pipeline, nullptr);
pipeline = VK_NULL_HANDLE;
layout = VK_NULL_HANDLE;
}
}
};

struct MaterialInstance {
Expand Down
Loading